Make Slice a record using StableValue (JDK25 preview) #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the https://github.com/openjdk/jdk/blob/5cc86738411c36378b89d8f4932a54b3089cf22e/src/hotspot/share/ci/ciField.cpp#L216 record fields are treated as trusted final, which makes them eliglble for inlining/constant folding.
Contributor
Author
|
This requires a preview API of |
Contributor
Author
wendigo
changed the title
Member
|
BTW, this looks great. We should do this when the API stablizes a bit more... 26 updated the api |
Contributor
Author
|
@dain it won't stabilize before 28. 27 targets 3rd preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the https://github.com/openjdk/jdk/blob/5cc86738411c36378b89d8f4932a54b3089cf22e/src/hotspot/share/ci/ciField.cpp#L216 record fields are treated as trusted final, which makes them eliglble for inlining/constant folding.