feat: add DEFAULT_SOCKET_TIMEOUT constant to overide default #46
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a new DEFAULT_SOCKET_TIMEOUT constant set to 15 seconds and applies it to both synchronous and asynchronous socket.io client initializations in the streaming client. The change increases the socket timeout from the python-socketio library's default (5 seconds) to 15 seconds.
- Added
DEFAULT_SOCKET_TIMEOUT = 15constant to centralize socket timeout configuration - Applied the constant to both
StreamConnectionandAsyncStreamConnectionclasses via therequest_timeoutparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aiola/constants.py | Introduces the DEFAULT_SOCKET_TIMEOUT constant with a value of 15 seconds |
| aiola/clients/stt/stream_client.py | Imports and applies DEFAULT_SOCKET_TIMEOUT to both synchronous and asynchronous socketio client configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15 insted of 5