Skip to content

Conversation

@stavelmashally
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 4, 2025 10:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Voice Activity Detection (VAD) parameters in the speech-to-text client. The implementation allows users to configure VAD settings such as threshold, minimum speech duration, minimum silence duration, and maximum segment duration for both streaming and file transcription operations.

  • Adds VadConfig dataclass with optional VAD parameters
  • Integrates vad_config parameter into both sync and async transcribe_file and stream methods
  • Includes comprehensive test coverage for VAD configuration scenarios

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
aiola/types.py Defines VadConfig dataclass with threshold, min_speech_ms, min_silence_ms, and max_segment_ms fields
aiola/clients/stt/client.py Adds vad_config parameter support to streaming and file transcription methods with validation
tests/unit/stt/test_stt_client.py Comprehensive test coverage for VAD configuration in both sync and async operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@stavelmashally stavelmashally merged commit 572f214 into main Sep 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants