Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the build toolchain from Rollup to Vite and the test framework from Mocha/Chai to Vitest. The changes include:
- Migration from Rollup to Vite for bundling
- Test framework migration from Mocha/Chai to Vitest
- Removal of Babel configuration
- Addition of extensive Spacewalk integration code for live maps
- Refactoring of dataset architecture to support both static Hi-C files and dynamic live maps
- CSS build improvements with SCSS module system
Reviewed Changes
Copilot reviewed 33 out of 45 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated build tool dependencies from Rollup to Vite, test framework from Mocha to Vitest |
| vite.config.js | New Vite configuration for building library bundles |
| vitest.config.js | New Vitest configuration for running tests |
| vite-plugin-version.js | Custom Vite plugin to update version from package.json |
| js/hicDataset.js | Refactored to abstract base class with HiCDataset subclass |
| js/liveMapDataset.js | New dataset implementation for live/computed contact maps |
| js/hicBrowser.js | Updated to support multiple dataset types with activeDataset/activeState |
| test/*.js | Migrated tests from Mocha/Chai to Vitest |
| css/juicebox.scss | Updated to use SCSS module system with @use |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.