Initialize store in local temporary directory in ZarrWriter#855
Open
spencerkclark wants to merge 4 commits intomainfrom
Open
Initialize store in local temporary directory in ZarrWriter#855spencerkclark wants to merge 4 commits intomainfrom
ZarrWriter#855spencerkclark wants to merge 4 commits intomainfrom
Conversation
spencerkclark
force-pushed
the
fix/avoid-need-for-delete-access-in-zarr-writer
branch
from
91d83ba to
9915e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR illustrates the fix proposed for #854.
This Beaker job shows that the changes in this PR enable writing zarr stores to GCS without any changes in permissions. The remote
experiment_dirin this case was:gs://vcm-ml-scratch/spencerc/2026-02-19-ace-2pctCO2-evaluator-test-remote-zarr-write.Changes:
Initializes the zarr store locally in a temporary directory before copying it to the final location within
ZarrWriter.initialize_store.Ensures that a
FileExistsErroris raised if the mode is"w-"and the specified path already exists—with this change we need to check this ourselves instead of relying on the zarr API.Tests added
Resolves #854