Use x-serverless-authorization header#53
Open
zucchinho wants to merge 2 commits intoahmetb:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the usual
Authorizationheader is already being used for other authentication, the X-Serverless-Authorization header can be used instead.Essentially this change just does that. If there is already any value present in
authorizationheader on the request, the OIDC token will be placed in thex-serverless-authorizationheader. Both are just as good for authenticating with Cloud Run. It will prioritize the value inx-serverless-authorizationif both are present.Also bumped go to 1.21, but happy to remove if deemed frivolous.