Fix CVEs #38
Open
Fix CVEs #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liberodark
force-pushed
the
CVE
branch
4 times, most recently
from
7bf14dd to
639c22e
Compare
lordnn
reviewed
Dec 4, 2025
| throw FI_MSG_ERROR_DIB_MEMORY; | ||
| } | ||
|
|
||
| if (cinfo.image_width > JPEG_MAX_DIMENSION || cinfo.image_height > JPEG_MAX_DIMENSION) { |
Contributor
There was a problem hiding this comment.
What's the difference from the if condition above?
lordnn
reviewed
Dec 4, 2025
| const int height = bmih.biHeight / 2; // height == xor + and mask | ||
| const unsigned bit_count = bmih.biBitCount; | ||
| if (bit_count != 1 && bit_count != 2 && bit_count != 4 && bit_count != 8 && bit_count != 16 && bit_count != 24 && bit_count != 32) { | ||
| return NULL; |
lordnn
reviewed
Dec 4, 2025
| FreeImage_OutputMessageProc(s_format_id, | ||
| "Unable to handle this format: bitspersample = 8, TIFFTAG_PLANARCONFIG = PLANARCONFIG_SEPARATE" | ||
| ); | ||
| throw (char*)NULL; |
lordnn
reviewed
Dec 4, 2025
| const uint32_t imageRowSize = (uint32_t)TIFFScanlineSize(tif); | ||
|
|
||
| if (width / tileWidth * tileRowSize * 8 > bitspersample * samplesperpixel * width) { | ||
| free(tileBuffer); |
Contributor
There was a problem hiding this comment.
free(std::unique_ptr<uint8_t[]>)???
lordnn
reviewed
Dec 4, 2025
| const uint32_t tileRowSize = (uint32_t)TIFFTileRowSize(tif); | ||
| const uint32_t imageRowSize = (uint32_t)TIFFScanlineSize(tif); | ||
|
|
||
| if (width / tileWidth * tileRowSize * 8 > bitspersample * samplesperpixel * width) { |
Contributor
There was a problem hiding this comment.
I think more correct condition is if (width / tileWidth * tileRowSize > dst_pitch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fix : #37