Skip to content

Add conditional formatting for checkbox#99

Merged
jules-exel merged 3 commits intomainfrom
fix-checkbox
Nov 12, 2025
Merged

Add conditional formatting for checkbox#99
jules-exel merged 3 commits intomainfrom
fix-checkbox

Conversation

@jules-exel
Copy link
Contributor

Add conditional formatting to remove margin bottom for checkbox to better align the label and checkbox

Current checkbbox:
current-checkbox

New checkbox:
new-checkbox

Non checkbox label still has margin bottom:
noncheckbox-label

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
plenum-ui Ready Ready Preview Comment Nov 12, 2025 4:01pm

label?: string;
truncateLabel?: boolean;
fullWidthLabel?: boolean;
isCheckbox?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit for this. Rather than calling it isCheckbox, it should be called something like noMarginBottom or noMargin or something along those lines just in case in the future another component needs it and it's not a checkbox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@DerekAgility DerekAgility left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jules!

@jules-exel jules-exel merged commit 03bb3c3 into main Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants