Added danger secondary type for Buttons#100
Merged
DerekAgility merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DerekAgility
commented
Dec 9, 2025
| type="button" | ||
| className={cn( | ||
| "inline-flex items-center justify-center gap-x-2 rounded-[3px] !ring-offset-white outline-none focus-visible:ring-2 focus-visible:ring-purple-600 focus-visible:ring-offset-2 focus-within:ring-2 focus-within:ring-purple-600 focus-within:ring-offset-2 focus:ring-2 focus:ring-purple-600 focus:ring-offset-2 active:ring-2 active:ring-purple-600 active:ring-offset-2 transition-all", | ||
| " px-4 py-2 inline-flex items-center justify-center gap-x-2 rounded !ring-offset-white outline-none focus-visible:ring-2 focus-visible:ring-purple-600 focus-visible:ring-offset-2 focus-within:ring-2 focus-within:ring-purple-600 focus-within:ring-offset-2 focus:ring-2 focus:ring-purple-600 focus:ring-offset-2 active:ring-2 active:ring-purple-600 active:ring-offset-2 transition-all", |
Contributor
Author
There was a problem hiding this comment.
Made the padding consistent here across sizes based and also made border radius 4px instead of 3px based on advice from Terrence
DerekAgility
commented
Dec 9, 2025
Comment on lines
+188
to
+190
| "border-gray-300 border bg-white text-red-600 hover:bg-red-50 focus-visible:!ring-red-500 focus:!ring-red-500 active:bg-red-100 active:ring-red-500 focus-within:!ring-red-500 disabled:bg-white disabled:text-red-300 disabled:!ring-0 disabled:focus-visible:ring-0": | ||
| actionType === "danger-secondary" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Styles for the new button type
DerekAgility
force-pushed
the
dlo/button-danger-secondary
branch
from
45d0f06 to
94f7bd3
Compare
DerekAgility
force-pushed
the
dlo/button-danger-secondary
branch
from
94f7bd3 to
7a4e36e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
danger-secondarybutton typeTo test