Open
Conversation
Contributor
Author
|
Should I better go with a new component or update exiting |
Contributor
|
This is wrong in so many ways it is not worth having. |
kudla
commented
Dec 1, 2020
Contributor
Author
kudla
left a comment
kudla
left a comment
There was a problem hiding this comment.
This is wrong in so many ways it is not worth having.
Would you be more specific please?
| # leads escaped quutes in the result command | ||
| # + helm --kube-context=busy-odilee-553.bubble.superhub.io --namespace=kubeflow-data upgrade mysql .charts/mysql --install --create-namespace --debug --wait --version 0.1.0 --values values.yaml \ | ||
| # --set ''\''mysqlUser=mysql''\'' --set ''\''mysqlPassword=somepass'\''' --set ''\''mysqlRootPassword=somepass''\'' --set ''\''persistence.existingClaim=mysql''\'' | ||
|
|
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I had an alternative way for exposing the exact values over HELM_OPTS just composing the extra --values set dynamically instead combined with hub templates interpolation.
I would be more safe but it seemed to be more messy same time regarding code structure.
akranga
requested changes
Dec 2, 2020
| - name: helm | ||
| parameters: | ||
| - name: repo | ||
| value: https://storage.googleapis.com/t3n-helm-charts |
There was a problem hiding this comment.
Why not to use: https://github.com/helm/charts/tree/master/stable/mysql ?
| @@ -0,0 +1,48 @@ | |||
| #!/bin/sh -xe | |||
|
|
|||
| HELM_OPTS="" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.