Migrate from fastutil to HPPC. Randomize tests.#16
Open
dweiss wants to merge 6 commits intoaggregateknowledge:masterfrom
Open
Migrate from fastutil to HPPC. Randomize tests.#16dweiss wants to merge 6 commits intoaggregateknowledge:masterfrom
dweiss wants to merge 6 commits intoaggregateknowledge:masterfrom
Conversation
…cit reference is simpler and straightforward. Converted from fastutil to HPPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This patch migrates the code from fastutil to HPPC collections. The difference is in size -- HPPC is about 15x smaller than fastutil and hll only requires a tiny set of functionality.
I've also migrated from testng to plain JUnit to be able to randomize tests (instead of running on a fixed seed all the time).
All tests pass with this change. Let me know if you're interested in incorporating it into the main line.