Fix compilation on targets with no alloc::sync::Arc and alloc,portable-atomic features
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecsocket
commented
Mar 24, 2025
aecsocket
commented
Mar 24, 2025
aecsocket
commented
Mar 24, 2025
Owner
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to compile the crate with
alloc,portable-atomicfeatures on a target likethumbv6m-none-eabiwhich has noalloc::sync::Arc(no pointer size atomics), compilation fails. This PR fixes this by usingportable-atomic-utilon those platforms, which provides anArcreplacement. This also adds toscripts/test.shto make sure this crate can compile onthumbv6m-none-eabi. The reason for picking this specific target is because Bevy also uses this as its reference "no-std/no-atomic-CAS" target.