Add agent installation and management system (#391) #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement comprehensive agent installation feature with support for: - Agent source resolution (catalog, git, URL, local) - Secure package downloading with caching - Agent validation and security checks - Dependency management for npm/pip/go packages - Complete CLI commands: add, list, remove agents - Example vector store agent template Features: • `agentuity add <source>` - Install agents from various sources • `agentuity add list` - List installed agents • `agentuity add remove <name>` - Remove installed agents • Comprehensive error handling with user-friendly messages • Security validation against malicious code patterns • Support for TypeScript, JavaScript, Python, and Go agents 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Move agent installation commands from root-level `add` to agent subcommands: • `agentuity add` → `agentuity agent add` • `agentuity add list` → `agentuity agent list-local` • `agentuity add remove` → `agentuity agent remove` This provides a more logical command structure where all agent-related operations are grouped under the `agent` command namespace, consistent with existing agent commands like `create`, `delete`, and `list`. Changes: - Remove cmd/add.go (standalone command) - Add agent installation subcommands to cmd/agent.go - Update command examples and help text - Maintain all existing functionality and flags 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
jhaynie
reviewed
Jun 19, 2025
Member
jhaynie
left a comment
jhaynie
left a comment
There was a problem hiding this comment.
some WIP comments but this is cool
| return fmt.Errorf("invalid agent name: %s (only alphanumeric, dots, underscores, and hyphens allowed)", agentName) | ||
| } | ||
|
|
||
| agentPath := filepath.Join(projectRoot, "agents", agentName) |
Member
There was a problem hiding this comment.
we need to use the project.Project object here and then
use theproject.Bundler.AgentConfig.Dir to get the dynamic source directory for agents
we also have a util.SafeProjectFilename for the agentname filename transformer that might be useful or at least you could add a method in that file to create a regex if you just need validation
|
|
||
| installer := agent.NewAgentInstaller(projectRoot) | ||
|
|
||
| agents, err := installer.ListInstalled() |
Member
There was a problem hiding this comment.
you could use reconcileAgentList and filter by the Local property too
|
|
||
| switch strings.ToLower(e.Language) { | ||
| case "typescript", "javascript": | ||
| msg += "\n\nTry:\n - Ensure npm is installed and accessible\n - Check your package.json exists\n - Run 'npm install' manually" |
Member
There was a problem hiding this comment.
also probably need to check if runtime is bun and switch between bun vs npm
| } | ||
|
|
||
| // Create agent directory | ||
| agentDir := filepath.Join(i.projectRoot, "agents", agentName) |
Member
There was a problem hiding this comment.
need to use our project directory since that is defined by template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement comprehensive agent installation feature with support for:
Features:
•
agentuity add <source>- Install agents from various sources •agentuity add list- List installed agents•
agentuity add remove <name>- Remove installed agents • Comprehensive error handling with user-friendly messages • Security validation against malicious code patterns • Support for TypeScript, JavaScript, Python, and Go agents🤖 Generated with Claude Code