Skip to content

fix: silence debug noise#86

Open
ZohaibHassan16 wants to merge 2 commits intoagentscope-ai:mainfrom
ZohaibHassan16:fix/issue-85
Open

fix: silence debug noise#86
ZohaibHassan16 wants to merge 2 commits intoagentscope-ai:mainfrom
ZohaibHassan16:fix/issue-85

Conversation

@ZohaibHassan16
Copy link

OpenJudge Version

0.2.0

Description

Just fixes the minor issues reported in #85 regarding unwanted console noise.

Checklist

Please check the following items before code is ready to be reviewed.

  • [ x] Code has been formatted with pre-commit run --all-files command
  • [ x] All tests are passing
  • [ x] Docstrings are in Google style
  • [ N/A] Related documentation has been updated (e.g. links, examples, etc.)
  • [x ] Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ZohaibHassan16, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the console output by adjusting logging levels and messages within the openai_chat_model.py file. The changes aim to reduce unnecessary debug information and provide clearer, more informative messages when handling model-specific compatibility, thereby improving the overall clarity and relevance of the application's console logs.

Highlights

  • Reduced Debug Output: A logger.debug statement related to enable_thinking=False for qwen models has been commented out to reduce console noise.
  • Improved Logging for Model Compatibility: A logger.warning message for qwen and gemini models switching to json_object response format has been changed to logger.info with a more descriptive message, indicating automatic compatibility handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reduces console noise by adjusting logging levels and messages. The change from a warning to an info log with a more descriptive message is a good improvement. My only suggestion is to completely remove the commented-out debug log line to enhance code maintainability, for which I've provided a specific comment.

kwargs["extra_body"] = {}
kwargs["extra_body"]["enable_thinking"] = False
logger.debug("Set enable_thinking=False in extra_body for qwen model")
# logger.debug("Set enable_thinking=False in extra_body for qwen model")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve code maintainability, it's better to remove this line completely rather than commenting it out. Commented-out code can become stale and lead to confusion for future developers.

kwargs["extra_body"] = {}
kwargs["extra_body"]["enable_thinking"] = False
logger.debug("Set enable_thinking=False in extra_body for qwen model")
# logger.debug("Set enable_thinking=False in extra_body for qwen model")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants