accomodate array in embedDistanceMatrix#3
Open
kmayerb wants to merge 1 commit intoagartland:masterfrom
Open
Conversation
accomodate array as input argument dmatDF in embedDistanceMatrix() see issue agartland#2 for explanation https://github.com/agartland/utils/blob/b61935a860838a0e70afde7c9ecf2c68f51a2c4b/embedding.py#L63-L69 Note that the upper portion of the function is meant to accomodate either numpy.array or pd.DataFrame passed to dmatDf, but if numpy array is supplied then L111 will raise an error: https://github.com/agartland/utils/blob/b61935a860838a0e70afde7c9ecf2c68f51a2c4b/embedding.py#L111 Example ```python embedDistanceMatrix(dmatDf = pd.DataFrame(tr.pw_beta[0:10,:][:,0:10]), method = "mds") ``` 👍 ```python embedDistanceMatrix(dmatDf = tr.pw_beta[0:10,:][:,0:10], method = "mds") ``` 👎 ``` AttributeError: 'numpy.ndarray' object has no attribute 'index' ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accomodate array as input argument dmatDF in embedDistanceMatrix()
see issue #2 for explanation
utils/embedding.py
Lines 63 to 69 in b61935a
Note that the upper portion of the function is meant to accomodate either numpy.array or pd.DataFrame passed to dmatDf, but if numpy array is supplied then L111 will raise an error:
utils/embedding.py
Line 111 in b61935a
Example
👍
👎