-
Notifications
You must be signed in to change notification settings - Fork 71
Refonte - Trésorerie - Journal - List #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vgreb
wants to merge
1
commit into
afup:master
Choose a base branch
from
vgreb:refacto/accounting-journal-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+481
−44
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace AppBundle\Accounting; | ||
|
|
||
| enum OperationType: int | ||
| { | ||
| case Debit = 1; | ||
| case Credit = 2; | ||
| case All = 0; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
sources/AppBundle/Controller/Admin/Accounting/Journal/ListAction.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace AppBundle\Controller\Admin\Accounting\Journal; | ||
|
|
||
| use AppBundle\Accounting\Entity\Repository\CategoryRepository; | ||
| use AppBundle\Accounting\Entity\Repository\EventRepository; | ||
| use AppBundle\Accounting\Entity\Repository\PaymentRepository; | ||
| use AppBundle\Accounting\Form\InvoicingPeriodType; | ||
| use AppBundle\Accounting\Model\Repository\InvoicingPeriodRepository; | ||
| use AppBundle\Accounting\Model\Repository\TransactionRepository; | ||
| use AppBundle\Accounting\OperationType; | ||
| use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| class ListAction extends AbstractController | ||
| { | ||
| public function __construct( | ||
| private readonly TransactionRepository $transactionRepository, | ||
| private readonly CategoryRepository $categoryRepository, | ||
| private readonly EventRepository $eventRepository, | ||
| private readonly PaymentRepository $paymentRepository, | ||
| private readonly InvoicingPeriodRepository $invoicingPeriodRepository, | ||
| ) {} | ||
|
|
||
| public function __invoke(Request $request): Response | ||
| { | ||
| $periodId = $request->query->has('periodId') ? $request->query->getInt('periodId') : null; | ||
| $period = $this->invoicingPeriodRepository->getCurrentPeriod($periodId); | ||
| $formPeriod = $this->createForm(InvoicingPeriodType::class, $period); | ||
| $periods = $this->invoicingPeriodRepository->getAll(); | ||
| $withReconciled = $request->query->getBoolean('with_reconciled'); | ||
| $type = OperationType::from($request->query->getInt('type')); | ||
|
|
||
| $transactions = $this->transactionRepository->getEntriesPerInvoicingPeriod($period, !$withReconciled, $type->value); | ||
|
|
||
| return $this->render('admin/accounting/journal/list.html.twig', [ | ||
| 'periods' => $periods, | ||
| 'periodId' => $period->getId(), | ||
| 'formPeriod' => $formPeriod->createView(), | ||
| 'withReconciled' => $withReconciled, | ||
| 'type' => $type, | ||
| 'categories' => $this->categoryRepository->getAllSortedByName(), | ||
| 'events' => $this->eventRepository->getAllSortedByName(), | ||
| 'paymentTypes' => $this->paymentRepository->getAllSortedByName(), | ||
| 'transactions' => $transactions, | ||
| ]); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je n'ai pas compris de suite que c'était pour mapper la query, et vu que ça ne sert qu'à ça, je suis pas sûr que ce soit le bon namespace.
Là on pourrait penser que c'est un enum global à toute la tréso je trouve.
Peut-être le déplacer dans le même namespace que le controller ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai effectivement créer un enum dédié parce qu'il manquait un cas dans \AppBundle\Compta\Importer\OperationType.
Je vais voir si je trouve une solution pour fusionner les deux sinon je déplacerai dans le namespace du controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Au final, j'utilise le nouvel enum dans les classes d'import des relevés bancaire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Alors je vais faire mon relou mais là ça pose un nouveau problème pour moi.
Avec cette fusion, on se retrouve avec le code de l'import qui pourrait être dans un état invalide (type = all) alors que ce n'est actuellement pas du tout possible grâce à l'enum limité. Et si on doit avoir du code qui ne peut être QUE débit ou crédit, et bien là il faudrait vérifier à chaque fois que la valeur n'est pas all.
Je comprend bien que les notions soient proches, mais elle ne sont pour autant pas les mêmes. Et j'insiste surtout pour avoir déjà fait ce genre de fusion sur des projets boulot et je l'ai regretté après.
En vrai, vu comment l'enum est utilisé dans le controller, tu pourrais même t'en passer et faire un simple assert :
Vu que de toute façon l'enum est retransformé en int immédiatement après, autant s'éviter la confusion non ?