Forgotten final commit for purchases scanner fix #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 53.74% 53.74%
=======================================
Files 165 165
Lines 3606 3606
=======================================
Hits 1938 1938
Misses 1668 1668 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rotheem
reviewed
Nov 21, 2025
| const Spacer(), | ||
| GestureDetector( | ||
| onTap: () async { | ||
| if (tag == "") { |
Member
There was a problem hiding this comment.
Isn't the tag optional ?
Why do we require one ?
Member
Author
|
You (or @Malem38) explicitly asked me to put it back as mandatory, because we should want to filter by tag (the name of an event possibly, or the bus number) |
Marc-Andrieu
force-pushed
the
fix/fix/scanner
branch
from
c3bd86d to
9e22613
Compare
cotanoine
approved these changes
Nov 24, 2025
Marc-Andrieu
force-pushed
the
fix/fix/scanner
branch
from
9e22613 to
e631db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.