Big revamp: Auth/Repository/Router #561

guillaumetavernier · 2025-06-09T20:03:21Z

Full refacto of app routing

codecov-commenter · 2025-06-09T20:08:00Z

Codecov Report

Attention: Patch coverage is 14.28571% with 306 lines in your changes missing coverage. Please review.

Project coverage is 55.86%. Comparing base (ecfac07) to head (8e86bc5).

Files with missing lines	Patch %	Lines
lib/auth/providers/openid_provider.dart	30.00%	84 Missing ⚠️
lib/tools/repository/repository.dart	0.00%	75 Missing ⚠️
lib/auth/class/auth_request.dart	4.16%	23 Missing ⚠️
lib/tools/token_expire_wrapper.dart	0.00%	18 Missing ⚠️
lib/auth/class/auth_token.dart	40.00%	15 Missing ⚠️
lib/tools/functions.dart	0.00%	8 Missing ⚠️
lib/auth/repository/openid_repository.dart	0.00%	7 Missing ⚠️
lib/tools/providers/map_provider.dart	0.00%	6 Missing ⚠️
lib/version/repositories/version_repository.dart	0.00%	3 Missing ⚠️
lib/admin/providers/group_logo_provider.dart	0.00%	2 Missing ⚠️
... and 35 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   54.29%   55.86%   +1.56%     
==========================================
  Files         169      170       +1     
  Lines        3702     3693       -9     
==========================================
+ Hits         2010     2063      +53     
+ Misses       1692     1630      -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR implements a major refactor of the authentication, repository, and routing logic in the administration module by removing the usage of the tokenExpireWrapper, updating repository constructors to accept the provider reference, and cleaning up unused imports.

Removed tokenExpireWrapper calls from multiple UI pages to simplify asynchronous workflows.
Updated repository instantiations to use dependency injection via constructor parameters.
Removed outdated token management imports that are no longer needed.

Reviewed Changes

Copilot reviewed 261 out of 261 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
lib/admin/ui/pages/memberships/association_membership_detail_page/association_membership_information_editor.dart	Removed tokenExpireWrapper call from updateAssociationMembership process.
lib/admin/ui/pages/memberships/add_edit_user_membership_page/add_edit_user_membership_page.dart	Removed tokenExpireWrapper wrapping for user queries and group updates.
lib/admin/ui/pages/groups/group_page/group_page.dart	Removed tokenExpireWrapper call from group deletion confirmation.
lib/admin/ui/pages/groups/edit_group_page/search_user.dart	Removed tokenExpireWrapper in the remove group member callback.
lib/admin/ui/pages/groups/edit_group_page/edit_group_page.dart	Removed tokenExpireWrapper call from group update process.
lib/admin/ui/pages/groups/add_loaner_page/add_loaner_page.dart	Removed tokenExpireWrapper call in the onTap callback for adding loaners.
lib/admin/ui/pages/groups/add_group_page/add_group_page.dart	Removed tokenExpireWrapper call during group creation.
lib/admin/ui/pages/add_edit_structure_page/add_edit_structure_page.dart	Removed tokenExpireWrapper call during structure update/creation.
lib/admin/ui/admin.dart	Removed tokenExpireWrapper call from the onMenu callback in the top bar.
(Various repository and provider files)	Updated repository constructors to accept ref and set tokens, and removed obsolete tokenExpireWrapper imports.

Comments suppressed due to low confidence (2)

lib/admin/ui/pages/memberships/association_membership_detail_page/association_membership_information_editor.dart:123

Ensure that token expiration handling is appropriately maintained after removing the tokenExpireWrapper call in the update flow. If a new pattern is being adopted, verify that it covers all necessary error and token refresh scenarios.

await tokenExpireWrapper(ref, () async {

lib/admin/ui/pages/memberships/add_edit_user_membership_page/add_edit_user_membership_page.dart:61

Review the removal of tokenExpireWrapper in the asynchronous onChanged and group update callbacks to ensure that token expiration and error handling is still effectively managed by the new approach.

tokenExpireWrapper(ref, () async {

…fix route uri comparison + others

guillaumetavernier · 2025-06-14T16:33:51Z

lib/login/ui/app_sign_in.dart

+    final forwardedFrom =
+        QR.params[forwardedFromKey]?.toString() ?? AppRouter.root;
+    final redirectPath = ref.watch(
+      authRedirectServiceProvider.select(
+        (service) => service.getRedirect(forwardedFrom),


The service should take QR.currentPath instead

Suggested change

final forwardedFrom =

QR.params[forwardedFromKey]?.toString() ?? AppRouter.root;

final redirectPath = ref.watch(

authRedirectServiceProvider.select(

(service) => service.getRedirect(forwardedFrom),

final redirectPath = ref.watch(

authRedirectServiceProvider.select(

(service) => service.getRedirect(QR.currentPath),

guillaumetavernier · 2025-06-14T16:35:12Z

lib/login/ui/pages/sign_in_page/sign_in_page.dart

-                                        QR.to(pathForwarding.path);
+                                        QR.to(
+                                          QR.params['forwardedFrom']
+                                                  ?.toString() ??


Use the redirect service and do not access 'forwardedFrom' directly

guillaumetavernier · 2025-06-14T16:37:11Z

lib/login/ui/web/left_panel.dart

+    final forwardedFrom =
+        QR.params[forwardedFromKey]?.toString() ?? AppRouter.root;
+
+    final redirectPath = ref.watch(


guillaumetavernier · 2025-06-14T18:30:55Z

lib/routing/ui/loading_page.dart

+
+    if (redirectPath != null &&
+        Uri.parse(redirectPath).path != AppRouter.loading) {
+      Future.microtask(() {


guillaumetavernier · 2025-06-14T18:31:30Z

lib/routing/ui/no_module.dart

+        QR.params[forwardedFromKey]?.toString() ?? AppRouter.root;
+    final redirectPath = ref.watch(
+      authRedirectServiceProvider.select(
+        (service) => service.getRedirect(forwardedFrom),


guillaumetavernier · 2025-06-14T18:32:54Z

lib/seed-library/ui/pages/add_edit_species_page/add_edit_species_page.dart

                              TypeMsg.msg,
-                              SeedLibraryTextConstants.addedSpecies,
+                              SeedLibraryTextConstants.updatedSpecies,
                            );


I did not touch that

guillaumetavernier · 2025-06-14T18:35:28Z

lib/tools/functions.dart

+
+void removeQueryParam(String keyToRemove) {
+  final params = QR.params.asMap;
+  params.remove(keyToRemove);
+  QR.params.updateParams(QParams(params: params));
+}
+
+void addQueryParam(String key, String value) {
+  final params = QR.params.asMap;
+  params[key] = ParamValue(value, keepAlive: true);
+  QR.params.updateParams(QParams(params: params));
+}


Can be cleaned up

guillaumetavernier · 2025-06-14T18:36:34Z

lib/tools/providers/map_provider.dart

-          setTData(t, AsyncData([value]));
-        }
-      });
+    loader(t).then((value) {


Probably what caused the bug with autoloader (fixed)

guillaumetavernier · 2025-06-14T18:38:06Z

lib/tools/ui/builders/auto_loader_child.dart

-      loader == null
-          ? notifier.autoLoadList(ref, mapKey, listLoader!)
-          : notifier.autoLoad(ref, mapKey, loader!);
+      Future(


…d not the current page

… token expiration

…ion during refresh

guillaumetavernier force-pushed the improve-router branch from e44641b to 53cc974 Compare June 9, 2025 20:08

guillaumetavernier changed the base branch from main to repo-refacto June 9, 2025 20:10

guillaumetavernier force-pushed the improve-router branch from 53cc974 to c46e204 Compare June 11, 2025 22:44

guillaumetavernier changed the base branch from repo-refacto to main June 14, 2025 15:22

guillaumetavernier changed the title ~~Improvement on router when refreshing on web~~ Big revamp: Auth/Repository/Router Jun 14, 2025

guillaumetavernier force-pushed the improve-router branch 2 times, most recently from 4c8b9d3 to 3606c7b Compare June 14, 2025 15:30

guillaumetavernier requested a review from Copilot June 14, 2025 15:33

Copilot AI reviewed Jun 14, 2025

View reviewed changes

guillaumetavernier added 5 commits June 14, 2025 18:11

refacto auth

af1040c

refacto repository/token expire wrapper + demo refacto type

21a053b

refacto routing

0cf4489

fix auto load

af8dbd2

refacto renaming + suppression token expire wrapper + refacto repo + …

8e86bc5

…fix route uri comparison + others

guillaumetavernier force-pushed the improve-router branch from ee0ffbe to 8e86bc5 Compare June 14, 2025 16:19

armanddidierjean added the build label Jun 14, 2025

guillaumetavernier commented Jun 14, 2025

View reviewed changes

guillaumetavernier added 4 commits June 14, 2025 22:28

fix(auth): add centralized lock to prevent race conditions

0033416

fix(loading): wait until the user is fetched when logged in

e600706

fix(auth): fix multiple listen on SSO windows creating race condition

79868e1

fix(quit-dialog): fix dialog staying open on sign out

cdbf165

guillaumetavernier added 7 commits June 15, 2025 01:11

fix(redirect-service): fix page calling the service on the forward an…

1372c65

…d not the current page

revamp(token-expire-wrapper): modify the function to prevent 403 from…

38c7bbf

… token expiration

refresh token on AuthNotifier init

249b78d

refacto(repo) remove setToken

6253419

fix:(loan): fix a crash when there are no loaner

10da573

fix(logo-repo): set token on init

d57beea

fix(logo-repo): use token expire wrapper on this repo

f7111d1

guillaumetavernier force-pushed the improve-router branch from f69587a to f7111d1 Compare June 17, 2025 16:51

guillaumetavernier added 6 commits June 17, 2025 19:22

fix(notifier): prevent load method to modify disposed state

9cff434

fix(loading): add module root to the app loading

2b08a14

fix(repo) manage 204

fd75a54

fix(repo) declare repo for each provider

5517b24

fix(repo): clean imports

ab0a941

FIX:(token-refresh): use internal notifier state to avoid race condit…

5d9a74c

…ion during refresh

Marc-Andrieu assigned guillaumetavernier Oct 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Big revamp: Auth/Repository/Router #561

Big revamp: Auth/Repository/Router #561

Uh oh!

guillaumetavernier commented Jun 9, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Jun 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

guillaumetavernier Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Big revamp: Auth/Repository/Router #561

Are you sure you want to change the base?

Big revamp: Auth/Repository/Router #561

Uh oh!

Conversation

guillaumetavernier commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guillaumetavernier commented Jun 9, 2025 •

edited

Loading

codecov-commenter commented Jun 9, 2025 •

edited

Loading