Skip to content

Conversation

@Marc-Andrieu
Copy link
Member

@Marc-Andrieu Marc-Andrieu commented Dec 10, 2025

Description

Summary

See my memo at #925, the goal of this PR is to resolve the heap of things in this issue.

Issues/PR dependencies

Issues to be resolved

Fixes #925

Required PRs

Changes Made

  • CoreUsersFactory
    • Valid ASCII emails
    • Catch collisions
    • Don't crash if exactly 1 demo user
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: see Improve the README #925

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu added documentation Improvements or additions to documentation fix bug This PR fix a bug labels Dec 10, 2025
@Marc-Andrieu Marc-Andrieu marked this pull request as draft December 10, 2025 09:22
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.85%. Comparing base (5fd6ace) to head (2500759).

Files with missing lines Patch % Lines
app/core/users/factory_users.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   84.86%   84.85%   -0.02%     
==========================================
  Files         193      193              
  Lines       13888    13892       +4     
==========================================
+ Hits        11786    11788       +2     
- Misses       2102     2104       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix bug This PR fix a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the README

2 participants