Skip to content

Conversation

@Marc-Andrieu
Copy link
Member

@Marc-Andrieu Marc-Andrieu commented Nov 29, 2025

Description

Summary

Renaming MyECLPay to MyPayment for 2 reasons:

  • Compatibility with CalypSSO: For Let admins invalidate the password of selected users #879 I need a change on CalypSSO, but the current latest (2.6.1) breaks Hyperion, hence this refacto is required
  • Genericity: not hard-coding our school's name in the internal payment solution to make it easier to fork and deploy for other schools

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • Renaming myeclpay to mypayment to fix CalypSSO compatibility
  • Refacto for CalypSSO to work
  • Refactor the displayname for the front-end

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@aeecleclair aeecleclair deleted a comment from gitguardian bot Nov 29, 2025
@aeecleclair aeecleclair deleted a comment from gitguardian bot Nov 29, 2025
@aeecleclair aeecleclair deleted a comment from gitguardian bot Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 90.43716% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.92%. Comparing base (f02f39f) to head (6690f97).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
app/core/mypayment/endpoints_mypayment.py 84.81% 29 Missing ⚠️
app/core/mypayment/cruds_mypayment.py 83.33% 3 Missing ⚠️
app/core/core_endpoints/endpoints_core.py 88.23% 2 Missing ⚠️
app/core/mypayment/integrity_mypayment.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +0.01%     
==========================================
  Files         193      192       -1     
  Lines       14969    14980      +11     
==========================================
+ Hits        12861    12872      +11     
  Misses       2108     2108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu changed the title Rename MyECLPay to MyPayment for genericity and prepare CalypSSO bump Rename MyECLPay to MyPayment for genericity & bump CalypSSO Nov 30, 2025
@Marc-Andrieu Marc-Andrieu added the dependencies Pull requests that update a dependency file label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE code quality dependencies Pull requests that update a dependency file fix bug This PR fix a bug migration myeclpay

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants