MyECLPay's 2nd payment method: the "classical" purchase #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
As of now, MyECLPay has only one payment method: the QR Code scanning, involving a seller user who makes the API call.
This PR adds a second payment method: the "classical" purchase, involving only the buyer, who makes the API call themself.
This 2nd payment method is meant to be used by other modules: AMAP, purchases itself, web front-ends indirectly (CdR, ...), etc.
Changes Made
TransactionRequestInfomodel (the one with the total amount, the IAT, the signature etc), theUsedTransactionRequesttable for idempotency (can't be debited twice if retrying),INDIRECTtransaction type (because distant, as opposed toDIRECTfor scanning which involves a direct seller user). Also the history types has newINDIRECT_GIVENandINDIRECT_RECEIVED(the direct transaction type is still associated toGIVENandRECEIVED), I'm not sure of this design however!Additional Notes
Differences with the scan payment method:
storebool: because the path is/myeclpay/stores/{store_id}/purchase, you can only pay a store by designClassification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments