-
Notifications
You must be signed in to change notification settings - Fork 9
Update README.md, and various related changes #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21468011 | Triggered | RSA Private Key | ba94061 | config.template.yaml | View secret |
| 21445366 | Triggered | Generic Password | 88d9e6d | config.template.yaml | View secret |
| 7298668 | Triggered | Generic High Entropy Secret | ba94061 | config.template.yaml | View secret |
| 21445367 | Triggered | Company Email Password | 88d9e6d | config.template.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 84.87% 84.86% -0.01%
==========================================
Files 193 193
Lines 13895 13888 -7
==========================================
- Hits 11793 11786 -7
Misses 2102 2102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b87be9a to
ebe1caf
Compare
e40d0e6 to
9f44cbb
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
093dd51 to
7f245f1
Compare
## Description ### Summary <!--Brief description of what this PR does.--> Bug: his unexpected comment explains why new users don't have their avatar imported through our SSO to the Matrix server. Feature: it seems the MAS (Matrix Authentication Service) now supports the `picture` claim of the OIDC scope, so we add it [back]. Source: https://github.com/element-hq/matrix-authentication-service/blob/1bd1b00524a62e365cf06b3745d298a53df69c90/crates/jose/src/claims.rs#L525 ## Type of Change We present it as a feature but it's actually a bug fix... - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [x] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [x] Other: 3rd party service integration ## Testing - [ ] Added/modified tests that pass the CI - [ ] Tested in a pre-prod - [ ] Tested this locally - [x] Will be tested in prod directly... ## Documentation - [ ] Updated docs accordingly (docs.myecl.fr) : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] Code includes docstrings - [x] No documentation needed
# Conflicts: # .github/workflows/publish.yml # .github/workflows/publishbase.yml # Dockerfile # Dockerfile.base # pyproject.toml # requirements.txt
bb58263 to
731e58f
Compare
Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
# Conflicts: # .github/workflows/test.yml # Dockerfile # app/core/myeclpay/endpoints_myeclpay.py # pyproject.toml # requirements.txt
See the commits for a (rather) clear-cut view of the changes --------- Co-authored-by: Timothée Robert <114694873+Rotheem@users.noreply.github.com> Co-authored-by: Armand Didierjean <95971503+armanddidierjean@users.noreply.github.com>
See the commits for a (rather) clear-cut view of the changes