Misc Contacts for PE5 #693
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 81.88% 82.00% +0.12%
==========================================
Files 152 156 +4
Lines 10862 10956 +94
==========================================
+ Hits 8894 8985 +91
- Misses 1968 1971 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/test_contact.py:15
- [nitpick] Consider refactoring to avoid module-level global variables for tokens and contact. Use fixtures that yield these values instead to improve test isolation and maintainability.
token_simple: str
|
Consider writing in code comments that it is instead for the future "satefy cards" website... few know the context! Also, where is the AuthClient to authenticate via MyECL ? |
|
Last but not least: a (super)module for miscellaneous small (sub)modules sounds like a good idea to me (see |
app/modules/misc/models_misc.py
Outdated
| class Contacts(Base): | ||
| __tablename__ = "misc_contacts" | ||
|
|
||
| id: Mapped[PrimaryKey] | ||
| creation: Mapped[datetime] | ||
| name: Mapped[str] | ||
| email: Mapped[str | None] | ||
| phone: Mapped[str | None] | ||
| location: Mapped[str | None] |
Description
This PR add a miscellaneous module for some stuff.
It adds contacts information for a website from PE5 to protect information about contact on the campus such as phone, number, location in order to not leak them on Internet directly.
Checklist