Skip to content

Conversation

@Flaim-X2
Copy link

Replace float with int.

@Flaim-X2 Flaim-X2 added fix bug This PR fix a bug feat New feature or request amap tombola migration labels Mar 18, 2025
Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please decomment or remove commented code

Flaim-X2 and others added 5 commits April 1, 2025 13:12
@Rotheem Rotheem dismissed armanddidierjean’s stale review April 1, 2025 11:17

Stop using request changes as you don't review the PR again when fixed

Using "bypass rules" every time is not a normal situation

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.17%. Comparing base (f02f39f) to head (a837c66).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
app/modules/amap/endpoints_amap.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #686       +/-   ##
===========================================
- Coverage   85.91%   55.17%   -30.75%     
===========================================
  Files         193      193               
  Lines       14969    14980       +11     
===========================================
- Hits        12861     8265     -4596     
- Misses       2108     6715     +4607     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should test it carefully with the front

This PR adds names to deliveries from the Amap module

---------

Co-authored-by: Lühmos <guillaume.foucher.pele@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants