-
Notifications
You must be signed in to change notification settings - Fork 9
AMAP in cents #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
AMAP in cents #686
Conversation
armanddidierjean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please decomment or remove commented code
# Conflicts: # app/modules/amap/endpoints_amap.py # app/modules/amap/models_amap.py
Stop using request changes as you don't review the PR again when fixed
Using "bypass rules" every time is not a normal situation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
===========================================
- Coverage 85.91% 55.17% -30.75%
===========================================
Files 193 193
Lines 14969 14980 +11
===========================================
- Hits 12861 8265 -4596
- Misses 2108 6715 +4607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
armanddidierjean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should test it carefully with the front
This PR adds names to deliveries from the Amap module --------- Co-authored-by: Lühmos <guillaume.foucher.pele@gmail.com>
Replace float with int.