Fix: change <p> to <div> in card description #24
Conversation
add classnames for description and title
There was a problem hiding this comment.
I was wrong when I said to make the <p> in CardDescription a <div>. I was confusing it with my reasoning for modifying AccordionContent, where it acts as a container and wrapped all children in a <p>. In this case CardHeader takes the role of the container which can contain arbitrary content, meaning CardTitle and CardDescription should remain as styled <h2> and <p> elements.
I do like adding class names to CardTitle and CardDescription though, this allows additional <h2> and <p> elements to exist in a CardHeader without singlestage styling them.
| <CardHeader> | ||
| <CardTitle>"Log in to your account"</CardTitle> | ||
| <CardTitle> | ||
| <p>"Log in to your account"</p> |
There was a problem hiding this comment.
This shouldn't contain a <p> because CardTitle already wraps children in a <h2>.
|
|
||
| view! { | ||
| <p {..global_attrs_1} {..global_attrs_2}> | ||
| <div |
There was a problem hiding this comment.
I know we talked about it and I said to make this a <div> but I was wrong, Please make this a <p> again.
| </CardTitle> | ||
| <CardDescription> | ||
| "Enter your details below to log in to your account" | ||
| <p>"Enter your details below to log in to your account"</p> |
There was a problem hiding this comment.
Remove this <p> to support other requested changes.
2 participants
add classnames for description and title