-
Notifications
You must be signed in to change notification settings - Fork 52
Split packages/core into packages/core and packages/browser #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Serban has identified some issues
|
|

Warning
This PR is based off of #1414, which itself is based off of #1412, so this should not be merged until they are.
Description
This PR changes the publishing artifact from being the packages/core folder to a new folder called packages/browser. And that folder gets the @adobe/alloy, and then the core folder appropriately gets the name @adobe/alloy-core. The intent is that both of these packages will be published to NPM.
The core package will be buildless, and then all build steps as well as integration and functional tests, anything to do with a browser stays in the browser package.
No functionality or browser specific functionality has been removed from the packages, the core package, but that is kind of the next step, and hopefully that work can be parallelized.
As it stands right now, the CI test and the publishing workflow still need to be completed. But right now this branch is 95% done.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Checklist: