Skip to content

Conversation

@carterworks
Copy link
Collaborator

@carterworks carterworks commented Dec 5, 2025

Warning

This PR is based off of #1414, which itself is based off of #1412, so this should not be merged until they are.

Description

This PR changes the publishing artifact from being the packages/core folder to a new folder called packages/browser. And that folder gets the @adobe/alloy, and then the core folder appropriately gets the name @adobe/alloy-core. The intent is that both of these packages will be published to NPM.

The core package will be buildless, and then all build steps as well as integration and functional tests, anything to do with a browser stays in the browser package.

No functionality or browser specific functionality has been removed from the packages, the core package, but that is kind of the next step, and hopefully that work can be parallelized.

As it stands right now, the CI test and the publishing workflow still need to be completed. But right now this branch is 95% done.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks self-assigned this Dec 5, 2025
@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Dec 5, 2025
@carterworks carterworks marked this pull request as ready for review December 16, 2025 16:13
@carterworks
Copy link
Collaborator Author

carterworks commented Jan 7, 2026

Serban has identified some issues

  • Make custom build script default to outputting in the current directory, not the project root
  • There are a few package-level npm scripts that just run the root-level script, like for testing. This could lead to recursive script issues. If running tests for multiple packages at the same time, we should fix that.
  • Unit tests have been a little flakey
  • The typescript language server complains, when in the browser package, that there are no type definitions for the core package. We should create a base level TypeScript config at the top level and then each package should also have a TypeScript config, or even better jsconfig.json, and then use that package or that base level TypeScript config in each of the packages.
  • Be consistent in how .browserslist is used/defined/applied

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: 3b85575

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carterworks
Copy link
Collaborator Author

carterworks commented Jan 23, 2026

Current test failures are related to queueTimeMillis and are unrelated, maybe.

So we are ready to merge.

Ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Do not include this PR in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants