Skip to content

Conversation

@MichaelGoberling
Copy link
Contributor

No description provided.

@MichaelGoberling
Copy link
Contributor Author

App plugin is now outputting web action urls that point to the deploy service -> https://github.com/adobe/aio-e2e-tests/actions/runs/15535392853/job/43733091670#step:11:14

I think in this case we still want them to be adobeio-static urls

@MichaelGoberling
Copy link
Contributor Author

@purplecabbage purplecabbage requested review from Copilot June 16, 2025 18:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an authentication step to the app smoke test workflow so that subsequent commands run with a valid Adobe IO login.

  • Insert a new “Auth” step using adobe/aio-apps-action@3.3.0 configured via JWT secrets
  • Ensures the smoke test won’t fail due to missing login
Comments suppressed due to low confidence (3)

.github/workflows/app-smoke-test.yml:39

  • Add an explicit id: auth to this step so it’s easy to reference its outputs or status in later steps.
    - name: Auth

.github/workflows/app-smoke-test.yml:44

  • Verify that the action expects CLIENTID in uppercase; many actions use camelCase (e.g., clientId)—mismatched casing could cause an authentication failure.
        CLIENTID: ${{ secrets.JWT_CLIENTID }}

.github/workflows/app-smoke-test.yml:48

  • [nitpick] The input name KEY is very generic. If the action supports it, consider using PRIVATE_KEY or jwtPrivateKey to more clearly convey its purpose.
        KEY: ${{ secrets.JWT_PRIVATE_KEY }}

@MichaelGoberling MichaelGoberling merged commit 447db05 into master Jun 16, 2025
10 of 12 checks passed
@MichaelGoberling MichaelGoberling deleted the login-before-deploy branch June 16, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants