Skip to content

On tracked hook #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KevinVoortmansAdhese wants to merge 6 commits into
base: main
Choose a base branch
from
Open

On tracked hook #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cf0bd2
Added new Hooks
KevinVoortmansAdhese Oct 23, 2025
1048ae4
lint fixes
KevinVoortmansAdhese Oct 23, 2025
be14f2b
moved onImpressionTracked function in check + changed to minor changeset
KevinVoortmansAdhese Oct 23, 2025
8aaeaa3
chaning Hook mode from async to passive
KevinVoortmansAdhese Oct 24, 2025
fcb6d3a
Merge branch 'main' into onTrackedHook
KevinVoortmansAdhese Oct 24, 2025
ff170c8
fix eager rendering triggering twice bug
KevinVoortmansAdhese Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-roses-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@adhese/sdk": patch
---

Changing Tracked Hooks from Async to Passive.
8 changes: 4 additions & 4 deletions packages/sdk/src/slot/slot.composables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ export function useSlotHooks({ setup }: AdheseSlotOptions, slotContext: Ref<Adhe
runOnDispose: ReturnType<typeof createPassiveHook<void>>[0];
runOnEmpty: ReturnType<typeof createPassiveHook<void>>[0];
runOnError: ReturnType<typeof createPassiveHook<Error>>[0];
runOnImpressionTracked: ReturnType<typeof createAsyncHook<AdheseAd>>[0];
runOnViewableTracked: ReturnType<typeof createAsyncHook<AdheseAd>>[0];
runOnImpressionTracked: ReturnType<typeof createPassiveHook<AdheseAd>>[0];
runOnViewableTracked: ReturnType<typeof createPassiveHook<AdheseAd>>[0];
} & AdheseSlotHooks {
const [runOnBeforeRender, onBeforeRender, disposeOnBeforeRender] = createAsyncHook<AdheseAd>();
const [runOnRender, onRender, disposeOnRender] = createPassiveHook<AdheseAd>();
Expand All @@ -163,8 +163,8 @@ export function useSlotHooks({ setup }: AdheseSlotOptions, slotContext: Ref<Adhe
const [runOnDispose, onDispose, disposeOnDispose] = createPassiveHook();
const [runOnEmpty, onEmpty, disposeOnEmpty] = createPassiveHook();
const [runOnError, onError, disposeOnError] = createPassiveHook<Error>();
const [runOnImpressionTracked, onImpressionTracked, disposeOnImpressionTracked] = createAsyncHook<AdheseAd>();
const [runOnViewableTracked, onViewableTracked, disposeOnViewableTracked] = createAsyncHook<AdheseAd>();
const [runOnImpressionTracked, onImpressionTracked, disposeOnImpressionTracked] = createPassiveHook<AdheseAd>();
const [runOnViewableTracked, onViewableTracked, disposeOnViewableTracked] = createPassiveHook<AdheseAd>();

setup?.(slotContext, {
onBeforeRender,
Expand Down
31 changes: 16 additions & 15 deletions packages/sdk/src/slot/slot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,21 +201,22 @@
{ immediate: true, deep: true },
);

const isInViewport = useRenderIntersectionObserver({
options,
element,
hooks,
});

watch(
isInViewport,
async (newIsInViewport) => {
if (newIsInViewport && status.value !== 'rendered')
await slotContext.value?.render();
},
{ immediate: true },
);

if (!context.options.eagerRendering){

Check failure on line 204 in packages/sdk/src/slot/slot.ts

View workflow job for this annotation

GitHub Actions / lint 

Missing space before opening brace
const isInViewport = useRenderIntersectionObserver({
options,
element,
hooks,
});

watch(
isInViewport,
async (newIsInViewport) => {
if (newIsInViewport && status.value !== 'rendered')
await slotContext.value?.render();
},
{ immediate: true },
);
}
hooks.onDispose(() => {
disposeQueryDetector();
});
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/src/slot/slot.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ export type AdheseSlotHooks = {
/**
* Hook that is called when the slots impressions tracker is fired.
*/
onImpressionTracked: ReturnType<typeof createAsyncHook<AdheseAd>>[1];
onImpressionTracked: ReturnType<typeof createPassiveHook<AdheseAd>>[1];
/**
* Hook that is called when the slots impressions tracker is fired.
*/
onViewableTracked: ReturnType<typeof createAsyncHook<AdheseAd>>[1];
onViewableTracked: ReturnType<typeof createPassiveHook<AdheseAd>>[1];
};
export type AdheseSlotOptions = {
/**
Expand Down
Loading