Skip to content

Fix for grammar parser returning MATCH_END when partial match items exist #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emcgee wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix for grammar parser returning MATCH_END when partial match items exist #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c328c2d
Fix for grammar parser returning MATCH_END when existing partial matc…
Oct 9, 2014
2212dfe
Fix for grammar parser returning MATCH_END when existing partial matc…
Oct 9, 2014
bfad98e
Merge branch 'develop' of github.com:ringplus/ruby_speech into develop
Oct 10, 2014
1c72ef1
Merge branch 'develop' into develop
emcgee Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# [develop](https://github.com/benlangfeld/ruby_speech)
* Bugfix: Fix grammar parsing error where MATCH_END is returned even when a partial match exists on a separate item

# [3.0.0](https://github.com/benlangfeld/ruby_speech/compare/v2.4.0...v3.0.0) - [2018-07-10](https://rubygems.org/gems/ruby_speech/versions/3.0.0)
* Feature: Loosen and bump Nokogiri version to ~>1.8, >=1.8.3
Expand Down
3 changes: 2 additions & 1 deletion ext/ruby_speech/ruby_speech.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ static int is_match_end(pcre *compiled_regex, const char *input)
search = search_set;
}
search_input[input_size] = *search++;
result = pcre_exec(compiled_regex, NULL, search_input, input_size + 1, 0, 0,
result = pcre_exec(compiled_regex, NULL, search_input, input_size + 1, 0, PCRE_PARTIAL,
ovector, sizeof(ovector) / sizeof(ovector[0]));
if (result > -1) return 0;
if (result == PCRE_ERROR_PARTIAL) return 0;
}
return 1;
}
Expand Down