Open
Conversation
Owner
|
Thanks for the PR. I'm really not a fan of having inventory related functions in the main client. There's already one for the transaction id thing and I'd like to refactor it out at one point. |
Contributor
Author
|
The reason I added it to ManagedClient was because the InventoryManager cannot send packets, as it does not hold a reference to any NetworkManager. If InventoryManager held a NetworkManager reference, SendInventoryTransaction() could also be moved to the InventoryManager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the desired item is already in the hotbar, it is not necessary to move any items around. The client can tell the server the new selected hotbar slot and use the item there.