You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. Could you detail what does it fix exactly and in which case so I can check everything works properly? More importantly, could you confirm it doesn't break anything on vanilla ? Cause it's not the first "chat parsing fix" PR in this repo and the previous one broke the parsing on vanilla in favor of some modded servers.
The previous implementation completely ignored extra if it was a list of plain strings not wrapped in a compound. The changes only handle this additional case and do not impact any chat that was previously working fine.
Example that worked before and still works: {text:"Hello", extra:[{text:" World"}, {text:"!"}]}
Example that did not work before but will work now: {text:"Hello", extra:[" World","!"]}
Could you please link that previous PR? I was not able to find it. Found it: #72
You can find some previous PR messing up with the parsing in #38 and #72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.