Improve Windows installation scripts and documentation#16
Improve Windows installation scripts and documentation#16ademirrodrigo wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def coletar_nfe_distribuicao(session: Session, empresa: Empresa, nsu_inicial: str | None = None) -> List[Documento]: | ||
| """Executa a consulta no serviço NFeDistribuicaoDFe.""" | ||
| LOGGER.info("Iniciando coleta NFeDistribuicaoDFe para %s", empresa.cnpj) | ||
|
|
||
| # As linhas abaixo demonstram como a integração real deve ocorrer. | ||
| certificado, senha = carregar_certificado(empresa.cnpj, empresa.certificado_senha or "") | ||
|
|
There was a problem hiding this comment.
Even though the NFe distribution integration is intentionally commented out, coletar_nfe_distribuicao still calls carregar_certificado before returning the placeholder warning. carregar_certificado raises FileNotFoundError whenever the expected .pfx file is absent, so a fresh installation without certificates will crash as soon as the user triggers a collection, despite the feature being disabled. The certificate lookup should be deferred or conditioned on the real web-service call being enabled.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6900d155dee88329a267792bed0f790b