Skip to content

feat: change concurrency groups #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Jan 27, 2026
Merged

feat: change concurrency groups #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions adbc_drivers_dev/templates/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,16 @@
name: <{lang_human}> <{workflow_name}>

on:
<% if not release %>
pull_request:
branches:
- main
paths:
<% if not release %>
- "<{lang_subdir}>/**"
<% endif %>
<% for path in pull_request_trigger_paths %>
- <{path}>
<% endfor %>

<% endif %>
push:
<% if release %>
tags:
Expand Down Expand Up @@ -76,8 +75,12 @@ on:
<% endif %>

concurrency:
<% if environment %>
# Must share concurrency group with release workflow since it also builds/tests
group: ${{ github.repository }}-${{ github.ref }}-ci
group: ${{ github.repository }}-${{ github.ref }}-<{environment}>
<% else %>
group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }}
<% endif %>
cancel-in-progress: true

defaults:
Expand Down Expand Up @@ -226,7 +229,7 @@ jobs:

if [[ -f ci/scripts/pre-test.sh ]]; then
echo "Loading pre-test"
./ci/scripts/pre-test.sh
./ci/scripts/pre-test.sh ${{ matrix.platform }} ${{ matrix.arch }}
fi

<% if lang == "go" %>
Expand Down Expand Up @@ -393,7 +396,7 @@ jobs:

if [[ -f ci/scripts/pre-test.sh ]]; then
echo "Loading pre-test"
./ci/scripts/pre-test.sh
./ci/scripts/pre-test.sh ${{ matrix.platform }} ${{ matrix.arch }}
fi

docker ps
Expand Down Expand Up @@ -671,12 +674,16 @@ jobs:
persist-credentials: false
<% endif %>
- name: load package
<% if private or secrets["build:test"] %>
env:
<% if private %>
COLUMNAR_CLOUD_API_TOKEN: ${{ secrets.COLUMNAR_CLOUD_API_TOKEN }}
<% endif %>
<% if secrets["build:test"] %>
<% for name, val in secrets["build:test"].items() %>
<{name}>: ${{ secrets.<{val}> }}
<% endfor %>
<% endif %>
<% endif %>
working-directory: <{ lang_subdir }>
run: |
Expand All @@ -688,9 +695,9 @@ jobs:
if [[ -f .env.ci ]]; then
source .env.ci
fi

<% if private %>
export COLUMNAR_DRIVER_LICENSE_KEY=$(curl --silent --fail -XGET -H 'Content-Type: application/json' -H "Authorization: Bearer $COLUMNAR_CLOUD_API_TOKEN" https://heimdall.columnar.tech/trial_license)

<% endif %>
pixi exec -s adbc-driver-manager -s pyarrow -s pytest python -m pytest -vs ci/test_package.py

release:
Expand Down
1 change: 0 additions & 1 deletion adbc_drivers_dev/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def generate_workflows(args) -> int:
f"{lang}_release.yaml",
{
**params.to_dict(),
"pull_request_trigger_paths": [".github/workflows/go_release.yaml"],
"release": True,
"workflow_name": "Release",
"lang": lang,
Expand Down