Always use primary group for initgroups#456
Open
mattmix wants to merge 1 commit intoadaptivecomputing:6.1-devfrom
Open
Always use primary group for initgroups#456mattmix wants to merge 1 commit intoadaptivecomputing:6.1-devfrom
mattmix wants to merge 1 commit intoadaptivecomputing:6.1-devfrom
Conversation
When users are not members of their primary group[1], initgroups(3) being called with the group listed in the group_list parameter causes the primary group to be missing in supplemental group list for the launched job. This change will cause init_groups to always call initgroups(3) with the user's primary group so that it will continue to exist later on when setgid is called with the group from the group_list. Redacted example: ``` [user@login ~] # groups primarygrp secondarygrp # Unpatched node: [user@login ~] # qsub -I -W group_list=secondarygrp [user@compute ~] groups secondarygrp # Patched node: [user@login ~] # qsub -I -W group_list=secondarygrp [user@compute ~] groups secondarygrp primarygrp ``` [1] Happens when the user's entry in LDAP assigns them to a group, but they aren't added to the group member list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users are not members of their primary group[1], initgroups(3) being called with the group listed in the group_list parameter causes the primary group to be missing in supplemental group list for the launched job.
This change will cause init_groups to always call initgroups(3) with the user's primary group so that it will continue to exist later on when setgid is called with the group from the group_list.
Redacted example:
[1] Happens when the user's entry in LDAP assigns them to a group, but they aren't added to the group member list.