Conversation
Extract getDescendants from ContentModule into a standalone, parameterised utility function that accepts a findFn callback instead of relying on this.find(). Also updates AbstractApiUtils.stringifyValues usage to use the named export from adapt-authoring-api. Adds 9 unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
getDescendants is only used internally by ContentModule.delete with no external consumers. Call the standalone function directly and remove the class method and re-export from index.js. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDescendantsfromContentModuleinto a standalone parameterised utility inlib/utils/getDescendants.jsfindFncallback instead of relying onthis.find(), making it testable in isolationAbstractApiUtils.stringifyValues()usage in clone method to use namedstringifyValuesexport fromadapt-authoring-apiadapt-authoring-apito^2.0.0andadapt-authoring-coreto^2.0.0Test plan
getDescendantsutility tests passadapt-authoring-api@2.0.0is published🤖 Generated with Claude Code