Skip to content
This repository was archived by the owner on Feb 26, 2018. It is now read-only.

Conversation

@bussnet
Copy link

@bussnet bussnet commented Jul 5, 2016

add phpdoc for the methods, so with the barryvdh/laravel-ide-helper there is autocompletion with IDEs like PhpStorm

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage remained the same at 94.647% when pulling aec7d9f on bussnet:master into 8056cea on adamwathan:master.

@bussnet
Copy link
Author

bussnet commented Aug 18, 2016

now fixed the messed up indention

@coveralls
Copy link

coveralls commented Aug 18, 2016

Coverage Status

Coverage remained the same at 94.647% when pulling 398e247 on bussnet:master into 8056cea on adamwathan:master.

@SlyDave
Copy link

SlyDave commented Oct 3, 2016

I feel for this to be accepted there should also be descriptions

@param string $value
@param string $value Blah blah blah

@adamwathan
Copy link
Owner

I'm not worried about the descriptions at all, honestly. Will merge this if you can fix the merge conflicts @bussnet, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants