Ticket/19958 #47
Open
Ticket/19958 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` methods. Follow-up to [20545], [21037], [21354], [21383], [27497]. Props pmbaldha, nikitasolanki1812, sabernhardt, SergeyBiryukov. Fixes #63660. git-svn-id: https://develop.svn.wordpress.org/trunk@61271 602fd350-edb4-49c9-b593-d223f7449a82
…ed functions. This also improves consistency with other themes. Follow-up to [59146]. Fixes #64265. See #64226. Props hbhalodia, huzaifaalmesbah. git-svn-id: https://develop.svn.wordpress.org/trunk@61272 602fd350-edb4-49c9-b593-d223f7449a82
Duplicates the `@since 6.9.0` annotation on `esc_url()` to the two wrapper functions affected by the change. Props peterwilsoncc, westonruter. Fixes #52886. git-svn-id: https://develop.svn.wordpress.org/trunk@61273 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [6379], [8669]. Props rutujaparamane2004. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61275 602fd350-edb4-49c9-b593-d223f7449a82
…nt endpoint for notes. Fix an issue where notes could be accessed by unauthenticated users by using the single comment REST API endpoint and passing the comment ID (`/wp/v2/comments/<ID>`). This fix only affects the `note` type. Props adamsilverstein, peterwilsoncc, westonruter. See #44157. git-svn-id: https://develop.svn.wordpress.org/trunk@61276 602fd350-edb4-49c9-b593-d223f7449a82
…p text. Follow-up to [29484], [29646], [45147]. Props Guido07111975. Fixes #64289. git-svn-id: https://develop.svn.wordpress.org/trunk@61277 602fd350-edb4-49c9-b593-d223f7449a82
… the possible object types. In addition to a meta box being able to be added for a post, it can also be added for a comment or a link, or even nothing at all when on the Dashboard. Props opr18, nikunj8866, soyebsalar01, westonruter. See #64224. Fixes #64251. git-svn-id: https://develop.svn.wordpress.org/trunk@61278 602fd350-edb4-49c9-b593-d223f7449a82
…rary help text. This aims to make the styling of button references more consistent across the help tabs. Follow-up to [61277]. Props Guido07111975. Fixes #64289. git-svn-id: https://develop.svn.wordpress.org/trunk@61279 602fd350-edb4-49c9-b593-d223f7449a82
What was previously `mixed` is actually a speculation rule which can be more accurately be typed as `array<string, mixed>`. Additionally, the return value of `jsonSerialize` is fixed to indicate it returns an array of lists as opposed an array of associative arrays. Developed in WordPress#8946 Follow-up to [59837]. Props justlevine, johnbillion, westonruter. See #64238, #63268, #62503. git-svn-id: https://develop.svn.wordpress.org/trunk@61280 602fd350-edb4-49c9-b593-d223f7449a82
…link-template.php` functions. The phpdoc `@return` tags for these functions indicate they may return `null`. This also fixes "Missing return argument" warnings which an IDE may also complain about. Developed in WordPress#8955 Props justlevine. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61281 602fd350-edb4-49c9-b593-d223f7449a82
…get_items()`. Follow-up to [38832]. Props justlevine, johnbillion. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61282 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#8945 Follow-up to [58281]. Props justlevine. See #64238, #61072. git-svn-id: https://develop.svn.wordpress.org/trunk@61283 602fd350-edb4-49c9-b593-d223f7449a82
…in the File block. Follow-up to [43808]. Props lakshyajeet, truptikanzariya, sabernhardt, sourabhjain, SirLouen, poojapadamad, SergeyBiryukov. Fixes #59263. git-svn-id: https://develop.svn.wordpress.org/trunk@61284 602fd350-edb4-49c9-b593-d223f7449a82
Renames the support key to `visibility` to avoid conflicting with the Block Visibility plugin's existing `blockVisibility` key. Follow-up to [61014]. Props andrewserong, annezazu, cbravobernal, dlh, jorbin, joen, johnjamesjacoby, palak678, ramonopoly, talldanwp, tyxla, wildworks. Fixes #64272. git-svn-id: https://develop.svn.wordpress.org/trunk@61285 602fd350-edb4-49c9-b593-d223f7449a82
In [59673], a Grunt subtask was introduced to convert workflow file references in GitHub Action workflows from local ones to remote ones that target the `trunk` branch. The `workflow-references-local-to-remote` Grunt task should be run after creating a new numbered branch to take advantage of the work started in [58165]. This commit introduces a new target for the `clean` Grunt task: `workflows`. Running `grunt clean:workflows` will delete all workflow files that are not intended to exist outside of `trunk`. Another Grunt task (`post-branching`) has also been added as a way to group all tasks taht should run within a newly created branch. For now, this contains `clean:workflows` and `replace:workflow-references-local-to-remote`. But more can be added in the future as more aspects of the branching process are automated. Props johnbillion. See #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@61286 602fd350-edb4-49c9-b593-d223f7449a82
Safari only introduced support for alternative text in generated CSS content in version 17.4, released in 2024. This meets the latest two version declared for core browser support. But because `dashicons.css` is commonly required on the front-end for plugins and themes, this support impacts front-end users, and the browser support guidelines for core should not apply in this context. Follow up to [60885]. Props codex-m, sabernhardt, wildworks, joedolson, desrosj, welcher. Fixes #64266. git-svn-id: https://develop.svn.wordpress.org/trunk@61290 602fd350-edb4-49c9-b593-d223f7449a82
…` when dealing with potentially invalid images in `wp_read_image_metadata()`. Prior to PHP 8.5 a boolean value was silently ignored when being passed to `list()`, but in PHP 8.5 and higher this now triggers a PHP warning. This change adds an appropriate guard condition. Props swissspidy, adamsilverstein Fixes #64295 git-svn-id: https://develop.svn.wordpress.org/trunk@61291 602fd350-edb4-49c9-b593-d223f7449a82
…ation. In testing during the release candidacy for WordPress 6.9 it was found that the `extract_block()` method may do more work than is expected based off of its name. This change renames the method to `extract_full_block_and_advance()` to communicate that it does move the Block Processor forward and to hint at the fact that it also encompasses all inner blocks during that advance. Developed in WordPress#10538 Discussed in https://core.trac.wordpress.org/ticket/61401 Follow-up to [60939]. Props dlh, dmsnell, jonsurrell, westonruter. See #61401. git-svn-id: https://develop.svn.wordpress.org/trunk@61294 602fd350-edb4-49c9-b593-d223f7449a82
…tation text. Follow-up to [43808]. Props nidhidhandhukiya, sainathpoojary, kelvinballoo, ankit-k-gupta, pooja1210, karmatosed, sabernhardt, sandeepdahiya, SergeyBiryukov. Fixes #58100. git-svn-id: https://develop.svn.wordpress.org/trunk@61295 602fd350-edb4-49c9-b593-d223f7449a82
* Ensure that `wp_create_category()` returns `int` as opposed to `numeric-string`. * Rename `$cat_name` to `$category_name` to avoid abbreviating variables. * Update docblock to remove erroneous `int` for `$category_name` param when only `string` is intended. * Add missing tests for `wp_create_category()`. Developed in WordPress#8861 Props justlevine, westonruter. See #64238, #64226. git-svn-id: https://develop.svn.wordpress.org/trunk@61298 602fd350-edb4-49c9-b593-d223f7449a82
This updates various `@var` tags on class properties to correctly indicate that the props may be `null` or unset: * `WP_Dependencies::$all_queued_deps` is nullable by both `::enqueue()` and `::dequeue`. Also, the types of the keys and values are specified. * `WP_Duotone::$global_styles_presets` and `::$global_styles_block_names` start off unset and are only initialized by static classes. * `WP_Query::init()` and `WP_Rewrite::init()` are public methods that `unset()`s many class props. * `WP_Theme::cache_delete()` sets many props to `null`. Developed in WordPress#8953 Props justlevine, westonruter. See #64238, #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61299 602fd350-edb4-49c9-b593-d223f7449a82
* Correctly hint that `WP_Screen::$_show_screen_options` is null before being instantiated. * Correctly hint that `::get_option()`, `get_help_tab()` and `get_screen_reader_text()` can return null. * Ensure `$this->columns` is an `int`, by casting `$this->get_option( 'layout_columns', 'default' )` from its numeric string. Developed in WordPress#8860 Props justlevine, peterwilsoncc, westonruter. See #64238, #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61300 602fd350-edb4-49c9-b593-d223f7449a82
…yles revisions When retrieving global styles revisions through the REST API, any block style variations (e.g., `styles.blocks.core/group.variations.my-variation`) are being removed during `WP_Theme_JSON` sanitization. `WP_Theme_JSON` will only allow block style variations that are registered. This means user modifications to any theme block style variations were being stripped from global styles revisions when retrieved via the REST API. This commit registers theme-defined block style variations in `WP_REST_Global_Styles_Revisions_Controller::prepare_item_for_response` so that they can be properly parsed by `WP_Theme_JSON`, and therefore added to the global styles revisions REST API GET response. Props ramonopoly, aaronrobertshaw, ellatrix. Fixes #64292. git-svn-id: https://develop.svn.wordpress.org/trunk@61301 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#10533 Props huzaifaalmesbah, sabernhardt, palak678, westonruter. See #64224. Fixes #64277. git-svn-id: https://develop.svn.wordpress.org/trunk@61302 602fd350-edb4-49c9-b593-d223f7449a82
…n `switch`. This resolves static analysis warnings about an unreachable statement. Developed in WordPress#8956 Follow-up to [41131]. Props justlevine, johnbillion. See #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@61303 602fd350-edb4-49c9-b593-d223f7449a82
The impact on existing WordPress core code is expected to be minimal. The release updates some sniffs to account for changes in recent WordPress versions up to 6.9.0-RC2. References: * [https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/3.3.0 WPCS 3.3.0 release notes] * [WordPress/WordPress-Coding-Standards@3.2.0...3.3.0 Full list of changes in WPCS 3.3.0] Follow-up to [56695], [56799], [57378], [57986], [60523]. Props jrf, dingo_d, garyj, rodrigosprimo, johnjago, SergeyBiryukov. Fixes #64302. git-svn-id: https://develop.svn.wordpress.org/trunk@61306 602fd350-edb4-49c9-b593-d223f7449a82
…sing/corrected tags, and specific types. Developed in WordPress#10482 Props huzaifaalmesbah, dhruvang21, juanfra, sabernhardt, noruzzaman, ravichudasama01, westonruter. See #64224. Fixes #64211. git-svn-id: https://develop.svn.wordpress.org/trunk@61309 602fd350-edb4-49c9-b593-d223f7449a82
Replace regex-based HTML parsing with WP_HTML_Tag_Processor to properly extract text nodes from menu labels. This ensures only root-level text nodes are collected. Additionally, replace html_entity_decode() with WP_HTML_Decoder::decode_attribute() with the menu URL for consistent attribute decoding. Follow-up to [61124], [61126], [61127], [61142]. Props: dmsnell, madhavishah01, peterwilsoncc, wildworks. Fixes #64233. git-svn-id: https://develop.svn.wordpress.org/trunk@61310 602fd350-edb4-49c9-b593-d223f7449a82
…TPext` methods. This avoids a PHP warning when `::dirlist()` returns `false` under certain conditions: > `Warning: Trying to access array offset on value of type bool in wp-admin/includes/class-wp-filesystem-ftpsockets.php on line 326` Follow-up to [6779], [30678], [45226]. Props apermo, malt3, SergeyBiryukov. Fixes #63474. git-svn-id: https://develop.svn.wordpress.org/trunk@61311 602fd350-edb4-49c9-b593-d223f7449a82
…arch. This ensures that a plugin's "Deactivate" link is disabled for dependency plugins during searches when a dependent plugin is active. It also ensures the "Requires" metadata is shown for dependent plugins, and the "Required by" metadata is shown for dependency plugins. Developed in WordPress#10547 Follow-up to [57545]. Props hbhalodia, webdados, swissspidy, ravichudasama01. See #22316. Fixes #64288. git-svn-id: https://develop.svn.wordpress.org/trunk@61312 602fd350-edb4-49c9-b593-d223f7449a82
Support for non-HTML5 scripts was removed in [61415]. Removes obsolete tests and references to the non-HTML5 script behaviors including CDATA wrappers and `type` attributes. Developed in WordPress#10740. Follow-up to [61415]. Props jonsurrell, westonruter, mukesh27. Fixes #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61526 602fd350-edb4-49c9-b593-d223f7449a82
Update custom CSS validation to allow any CSS except `STYLE` close tags. Previously, some valid CSS would be rejected for containing HTML syntax characters, like this example:
{{{
@Property --animate {
syntax: "<custom-ident>"; /* <-- Validation error on `<` */
inherits: true;
initial-value: false;
}
}}}
Developed in WordPress#10667.
Follow-up to [61418], [61486].
Props jonsurrell, westonruter, peterwilsoncc, johnbillion, xknown, sabernhardt, dmsnell, soyebsalar01, dlh.
Fixes #64418.
git-svn-id: https://develop.svn.wordpress.org/trunk@61527 602fd350-edb4-49c9-b593-d223f7449a82
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @SergeyBiryukov602fd350-edb4-49c9-b593-d223f7449a82, @davidbaumwald602fd350-edb4-49c9-b593-d223f7449a82. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Follow-up to [7043], [7092], [8304], [9053], [21871]. Props huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61532 602fd350-edb4-49c9-b593-d223f7449a82
…evelop into ticket/19958
Remove the text color setting on the Written by pattern. The setting was resulting in color contrast that was well below contrast guidelines. Allow the text color to be inherited by default. Props poena, rinkalpagdar, narenin, sabernhardt, noruzzaman, huzaifaalmesbah, joedolson. Fixes #62982. git-svn-id: https://develop.svn.wordpress.org/trunk@61534 602fd350-edb4-49c9-b593-d223f7449a82
This reverts [61010]. Setting the sender address by default has shown to reduce deliverability for emails for sites that were working correctly in 6.8 and before. As reduced deliverability can harm IP reputation which means it's not just the single WordPress install that is harmed, [61010] is being reverted out of an abundance of caution. Follow up to [61010]. Props jorbin, dmsnell, SirLouen, wildworks, desrosj, siliconforks, digitalblanket, studiomondiale, zoe20, Monarobase, amanandhishoe, Fixes #64368.See #49687. git-svn-id: https://develop.svn.wordpress.org/trunk@61537 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [32642], [32654], [34021]. Props huzaifaalmesbah. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61538 602fd350-edb4-49c9-b593-d223f7449a82
…dating CSSLint, Esprima, HTMLHint, and JSONLint. This installs npm packages for `codemirror`, `csslint`, `esprima`, `htmlhint`, and `jsonlint` to replace the libraries which had been copied into SVN. A new `grunt build:codemirror` task is responsible for building CodeMirror as part of the build process. This finally revisits the original CodeMirror integration which was originally developed in the [https://github.com/WordPress/better-code-editing/ Better Code Editing] feature plugin in 2017. ||= Package =||= Old Version =||= New Version =|| || codemirror || 5.29.1-alpha-ee20357 || 5.65.20 || || esprima || 4.0.0 || 4.0.1 || || jsonlint || 1.6.2 || 1.6.3 || || htmlhint || 0.9.14-xwp || 1.8.0 || Follow-up to [41376]. Props westonruter, jonsurrell, tobiasbg, desrosj, adamsilverstein, WraithKenny, rafa8626, netweb. See #12423. Fixes #48456, #41870. git-svn-id: https://develop.svn.wordpress.org/trunk@61539 602fd350-edb4-49c9-b593-d223f7449a82
…ssages. Improve dependency warning messages so that list separators are localized according to the current locale when multiple dependencies are listed. Follow-up to [61323], [60999], [61357]. Props mukeshpanchal27, jorbin, westonruter, wildworks. See #64229. git-svn-id: https://develop.svn.wordpress.org/trunk@61542 602fd350-edb4-49c9-b593-d223f7449a82
The `react-refresh-entry.js` script was bundling its own copy of `react-refresh/runtime` instead of using the `window.ReactRefreshRuntime` global set up by `react-refresh-runtime.js`. This created two separate runtime instances: the entry script set up hooks on its bundled copy, while plugins called `performReactRefresh()` on the window global — a different instance with no hooks registered. This splits the development webpack config into two configs so that `externals` only applies to the entry script. The runtime config bundles `react-refresh/runtime` and exposes it as `window.ReactRefreshRuntime`, while the entry config uses that global as an external. Props manzoorwanijk, wildworks. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61543 602fd350-edb4-49c9-b593-d223f7449a82
This updates the core configuration to allow JS language features which area already shipping in core via Gutenberg packages. Obsolete `/* jshint esversion: 6 */` comments are also removed from JS files. Developed in WordPress#10808 Follow-up to [59963]. Props westonruter, jonsurrell, mukesh27. See #63077. Fixes #64562. git-svn-id: https://develop.svn.wordpress.org/trunk@61544 602fd350-edb4-49c9-b593-d223f7449a82
…ns in Grunt tasks. The `uglify:core` and `copy:files` tasks utilized broad negative glob patterns (`!**/*.min.js` and `!**/*.map`) to exclude files from processing. The glob expansion scans the entire `src/` directory tree, including `wp-content`. For environments where `wp-content` contains deep directory structures (such as plugins with `node_modules` dependencies) this traversal becomes prohibitively slow, causing the build process to hang. This change scopes the exclusion patterns to specific directories (e.g. `wp-admin`, `wp-includes`, default themes, and Akismet), limiting the file scan to relevant core paths and preventing unnecessary recursion into `wp-content`. In one dev environment, this reduces `npm run build:dev` from 43s to 9s, and `npm run build` from 51s to 13s. Developed in WordPress#10809 Follow up to [61475]. Props westonruter, jonsurrell. See #63606. Fixes #64563. git-svn-id: https://develop.svn.wordpress.org/trunk@61545 602fd350-edb4-49c9-b593-d223f7449a82
Co-authored-by: Adam Silverstein <adam@earthbound.com>
Co-authored-by: Adam Silverstein <adam@earthbound.com>
Co-authored-by: Adam Silverstein <adam@earthbound.com>
…ent when registering a post type. Props ocean90, mukesh27, johnbillion See #64224 git-svn-id: https://develop.svn.wordpress.org/trunk@61546 602fd350-edb4-49c9-b593-d223f7449a82
…update related logic.
In [simplepie/simplepie#795 simplepie/simplepie#795] handling of multiple feed requests was deprecated, triggering the message `Fetching multiple feeds with single SimplePie instance is deprecated since SimplePie 1.9.0, create one SimplePie instance per feed and use SimplePie::merge_items to get a single list of items.` This updates `fetch_feed()` to handle multiple requests using seperate SimplePie instances in order to retain backward compatibility. A PHP 8.5 deprecation was throwing notices in the event an empty URL was passed to `fetch_feed()`, `Using null as an array offset is deprecated, use an empty string instead`. This includes a workaround pending the release of a SimplePie version including [simplepie/simplepie#949 simplepie/simplepie#949]. Fixes #64136. Props audrasjb, jorbin, muryam, oglekler, ozgursar, presskopp, swissspidy, westonruter, wildworks, peterwilsoncc. git-svn-id: https://develop.svn.wordpress.org/trunk@61551 602fd350-edb4-49c9-b593-d223f7449a82
…ed functions. This also improves consistency with other themes. Follow-up to [56716], [61272]. Props huzaifaalmesbah, mukesh27, sabernhardt. See #64226. git-svn-id: https://develop.svn.wordpress.org/trunk@61552 602fd350-edb4-49c9-b593-d223f7449a82
…hoisting late-printed styles. This refactors `wp_hoist_late_printed_styles()` to strictly preserve the classic theme CSS cascade when moving styles from `wp_footer` to the `HEAD`. Previously, hoisted styles were appended in an order closer to the CSS cascade for block themes, potentially causing specificity issues for CSS selectors written for the previous cascade. This is intended to eliminate the need for sites which upgraded to 6.9 to apply a hotfix involving `add_filter( 'should_load_separate_core_block_assets', '__return_false' )` to disable the optimization. Key changes: * Identifies styles enqueued during `enqueue_block_assets`. * Separates core block styles from third-party block styles. * Inserts core block styles immediately after `wp-block-library`. * Inserts third-party block styles after `classic-theme-styles`. * Inserts `global-styles` after all `enqueue_block_assets` styles. This ensures the following order is maintained: 1. Core block library. 2. Core block styles. 3. Classic theme styles. 4. Third-party block styles. 5. Global styles. Developed in WordPress#10601 Follow-up to [61174], [61122], [61076], [61008]. Props westonruter, wildworks, jorbin, peterwilsoncc, sabernhardt, audrasjb, pmbs, threadi, madhavishah01, raftaar1191, noruzzaman, ozgursar. See #64099, #64150, #43258. Fixes #64354. git-svn-id: https://develop.svn.wordpress.org/trunk@61554 602fd350-edb4-49c9-b593-d223f7449a82
"At a glance" links in the dashboard were labeled with the count of published posts, but linked to the All posts view. Change the links so that they target only the published posts list and update link text to clarify. Props awardpress, birgire, benpinales, susiyanti, sergeybiryukov, sirlouen, noruzzaman, huzaifaalmesbah, westonruter, nikunj8866, joedolson. Fixes #43084. git-svn-id: https://develop.svn.wordpress.org/trunk@61555 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [58074], [61486]. Props huzaifaalmesbah, shailu25. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61557 602fd350-edb4-49c9-b593-d223f7449a82
…@covers` and `@ticket`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the UI
BUT acan't where to control the home page to swap to another archive CPT
Trac ticket: https://core.trac.wordpress.org/ticket/19958