Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
33e737e to
f9a91cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR hardens the composite action's defaults and runtime behavior across CLI install, proxy lifecycle checks, argument parsing, permission gating, and proxy config management.
User-facing impact
Before this change, action runs could incorrectly trust stale proxy server-info files, parse malformed JSON
codex-argswithout validation, and write duplicate/legacy proxy config entries over repeated runs. Bot bypass behavior also differed between code paths, creating surprising access-control behavior.With this change:
modelnow defaults togpt-5.3-codexwhile allowing opt-out withmodel: "".codex-versiondefaults to0.104.0for deterministic installs, while empty input still resolves to latest.codex-argsJSON parsing now enforces a JSON array of strings.allow-bots=falseconsistently.Root causes addressed
Fix details
probe-proxycommand and port reachability checks viasrc/probeProxy.ts.parseExtraArgshelper with strict JSON-array/string validation and tests.writeProxyConfigto render managed blocks idempotently and strip legacy blocks safely.[table],[[array_table]], and inline-comment headers to avoid accidental config loss.Validation
pnpm test(18 passing tests)pnpm run build