keep min package versions from deletion #52

NamrataJha · 2021-11-08T07:25:39Z

This PR adds

A min-versions-to-keep option for setting a lower limit on package versions while deleting.
A ignore-versions option to set regex for packages to be ignored while deletion.
A delete-only-pre-release-versions option to delete only the pre-release versions for a package
This integrates the changes from PR #29, PR #10 and resolves additional conflicts on those branches.

New Feature

Specify a minimum number of latest package versions to always keep while deleting.
- Use the min-versions-to-keep attribute with the action workflow.
- This is not a mandatory field for running the action. When not specified, by default the value is 0 and at every run num-old-versions-to-delete package versions will get deleted.
- When min-versions-to-keep is set to any value greater than 0, it will delete maximum possible package versions except min-versions-to-keep package versions.
Specify package versions to ignore while deletion by regex pattern.
- Use the ignore-versions attribute within the action workflow.
- This is not a mandatory field. By default, no package version will be ignored.
Set to delete only pre-release versions.
- Use the delete-only-pre-release-versions attribute with the action workflow.
- This is not a mandatory field for running the action. By default, this is set to "false".
- When "true", number of pre-release versions to keep can be set using min-versions-to-keep with this option.

What to Test

Test using the latest commit of delete-package-versions action - actions/delete-package-versions@6fee3def5eefbcb45b0ab364630c00099189e727 to use the changes.
Specify value for min-versions-to-keep ignore-versions and delete-only-pre-release-versions and see if the behaviour is expected.

nadesu · 2021-11-08T09:02:16Z

@NamrataJha - pls add more details to description as to how the new features of Action can be used, its spec, etc.

nadesu · 2021-11-09T04:48:47Z

@NamrataJha - pls work with @jcansdale for any feedback

README.md

nishthaGupta

Approving.

README.md

NamrataJha · 2021-11-12T04:03:56Z

Have added an additional option ignore-versions to filter out packages to be deleted.

jcansdale

I think we should be a little more conservative about what versions we default to keeping. See inline comment for suggestion.

action.yml

src/delete.ts

README.md

NamrataJha · 2021-11-16T05:43:07Z

@jcansdale as per our discussion have updated to the action to-

remove ignore-versions default value. No package version will be ignored by default.
By default min-versions-to-keep is set to 1.
By default num-old-versions-to-delete is set to 1.
delete-only-pre-release-versions is the option for deleting all pre-release versions. This is false by default.
When delete-only-pre-release-versions is set to true, min-versions-to-keep is set to 0, num-old-versions-to-delete is set to 100 and ignore-versions is set to ^(0|[1-9]\\d*)((\\.(0|[1-9]\\d*))*)$ which includes all the release versions.

@AmrutaKawade Have made the above changes in the action and updated the README.md. Please review this once.

src/input.ts

README.md

src/input.ts

src/version/get-versions.ts

AmrutaKawade

LGTM

pulkitaggarwl · 2021-11-22T08:24:16Z

README.md

+  # Cannot be more than 100
+  min-versions-to-keep:
+
+  # The package versions to ignore exclude from deletion.


can we update the text to suggest that we are supporting regex here.

Sure will make the change.

jcansdale

Suggestions to make the new functionality more prominent/discoverable.

jcansdale · 2021-11-22T10:57:34Z

README.md

 * Delete version(s) of a package that is hosted in a different repo than the one executing the workflow
+* Delete maximum possible package versions except n latest versions
+* Ignore some versions based on name from deletion
+* Delete only pre-release versions


Could we say something like this:

Create a retention policy (delete all except n most recent pre-release versions)

And move this more common scenario to the top.

jcansdale · 2021-11-22T12:02:32Z

README.md

+  - [Delete all except y latest versions of a package hosted in a different repo than the workflow](#delete-all-except-y-latest-versions-of-a-package-hosted-in-a-different-repo-than-the-workflow)
+  - [Delete oldest x number of versions while ignoring particular package versions in the same repo as the workflow](#delete-oldest-x-number-of-versions-while-ignoring-particular-package-versions-in-the-same-repo-as-the-workflow)
+  - [Delete all except y latest versions while ignoring particular package versions in the same repo as the workflow](#delete-all-except-y-latest-versions-while-ignoring-particular-package-versions-in-the-same-repo-as-the-workflow)
+  - [Delete only pre-release package versions except y no of pre-release package versions in the same repo as the workflow](#delete-only-pre-release-package-versions-except-y-no-of-pre-release-package-versions-in-the-same-repo-as-the-workflow)


Can we move these two to the top?

I suspect the current top one, Delete a specific version of a package, is rarely if ever used! 😉

jcansdale

Looks good. 👍🏻

NamrataJha added 3 commits November 8, 2021 07:25

keep min package versions from deletion

1806103

update test

398a50a

update test

1f8196e

NamrataJha marked this pull request as ready for review November 8, 2021 08:10

NamrataJha requested a review from a team as a code owner November 8, 2021 08:10

update delete.ts

b5e7ea4

update README.md

90bcbbe

NamrataJha requested a review from nishthaGupta November 9, 2021 07:21

nishthaGupta reviewed Nov 9, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

update README.md

bd624e4

NamrataJha requested a review from nishthaGupta November 9, 2021 08:39

nishthaGupta approved these changes Nov 9, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

NamrataJha added 4 commits November 12, 2021 03:46

add ignore versions property

4ec126b

fix default regex

799007d

fix default regex string

7fdaaf4

fix default regex string

031ff89

NamrataJha requested a review from nishthaGupta November 12, 2021 04:11

jcansdale suggested changes Nov 12, 2021

View reviewed changes

action.yml Outdated Show resolved Hide resolved

fix regex to ignore all release versions

1ea7a48

AmrutaKawade reviewed Nov 15, 2021

View reviewed changes

src/delete.ts Outdated Show resolved Hide resolved

AmrutaKawade reviewed Nov 15, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

fi delete pre release version by default

0de5ea0

NamrataJha requested review from AmrutaKawade and removed request for nishthaGupta November 16, 2021 05:52

AmrutaKawade reviewed Nov 16, 2021

View reviewed changes

src/input.ts Outdated Show resolved Hide resolved

AmrutaKawade reviewed Nov 16, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

NamrataJha added 2 commits November 16, 2021 06:35

fix typo

79a5c93

allow min pre release versions to be set

e73aee7

NamrataJha requested a review from AmrutaKawade November 17, 2021 07:52

NamrataJha added 6 commits November 17, 2021 08:10

update input.ts

2dc6d27

fix package not found error

8d3af2e

fix error for deleting all pre-release versions

7f40a50

fix error for deleting all pre-release versions

b5e80e7

ignore num-versions-to-delete when min-version-to-keep is set

32b30cf

update README.md

6fee3de

NamrataJha requested a review from nishthaGupta November 18, 2021 08:04

AmrutaKawade reviewed Nov 18, 2021

View reviewed changes

src/input.ts Show resolved Hide resolved

AmrutaKawade reviewed Nov 18, 2021

View reviewed changes

src/version/get-versions.ts Show resolved Hide resolved

AmrutaKawade approved these changes Nov 18, 2021

View reviewed changes

pulkitaggarwl reviewed Nov 22, 2021

View reviewed changes

jcansdale suggested changes Nov 22, 2021

View reviewed changes

Update README.md

020712e

jcansdale approved these changes Nov 23, 2021

View reviewed changes

NamrataJha merged commit b19f4fe into main Nov 23, 2021

NamrataJha deleted the keep-min-packages branch November 25, 2021 14:49

keep min package versions from deletion #52

keep min package versions from deletion #52

Uh oh!

Conversation

NamrataJha commented Nov 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Feature

What to Test

Uh oh!

nadesu commented Nov 8, 2021

Uh oh!

nadesu commented Nov 9, 2021

Uh oh!

Uh oh!

nishthaGupta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NamrataJha commented Nov 12, 2021

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NamrataJha commented Nov 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AmrutaKawade left a comment

Choose a reason for hiding this comment

Uh oh!

pulkitaggarwl Nov 22, 2021

Choose a reason for hiding this comment

Uh oh!

NamrataJha Nov 22, 2021

Choose a reason for hiding this comment

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

jcansdale Nov 22, 2021

Choose a reason for hiding this comment

Uh oh!

jcansdale Nov 22, 2021

Choose a reason for hiding this comment

Uh oh!

jcansdale left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

NamrataJha commented Nov 8, 2021 •

edited

Loading