Add vendor wavetrend #271
Open
Add vendor wavetrend #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a description in package.json Build driver in current folder instead of dist folder
LenActility
requested changes
Feb 3, 2026
Contributor
LenActility
left a comment
LenActility
left a comment
There was a problem hiding this comment.
There is some issues regarding examples, I've highlighted them, those need to be fixed for the driver to be handled properly
If you have any questions, please feel free to contact us
| "output": { | ||
| "data": { | ||
| "timestamp": 1596398400, | ||
| "sensor_id": 0, |
Contributor
There was a problem hiding this comment.
'-' is what is written in your "examples.json" file.
'+' is what the test received as output
- "events": 1,
- "maxC": 21,
- "minC": 19,
- "reports": 1,
- "sensor_id": 0,
+ "events": 16,
+ "maxC": 80,
+ "minC": 49,
+ "reports": undefined,
+ "sensor_id": 1,
| "S2minC": 19, | ||
| "S2maxC": 21, | ||
| "S3minC": 19, | ||
| "S4maxC": 21 |
Contributor
There was a problem hiding this comment.
- "S1maxC": 21,
- "S1minC": 19,
- "S2maxC": 21,
- "S2minC": 19,
- "S3minC": 19,
- "S4maxC": 21,
+ "s1MaxC": 21,
+ "s1MinC": 19,
+ "s2MaxC": 21,
+ "s2MinC": 19,
+ "s3MaxC": 21,
+ "s3MinC": 19,
| "output": { | ||
| "data": { | ||
| "timestamp": 1596398400, | ||
| "pvd_level": 0, |
Contributor
There was a problem hiding this comment.
- "pvd_level": 0,
+ "pvd_level": 5,
| "pvd_level": 0, | ||
| "readings": [ | ||
| { | ||
| "timestamp": -1, |
Contributor
There was a problem hiding this comment.
- "timestamp": -1,
+ "timestamp": 1596398390,
| ] | ||
| }, | ||
| { | ||
| "timestamp": 0, |
Contributor
There was a problem hiding this comment.
- "timestamp": 0,
+ "timestamp": 1596398400,
| }, | ||
| "output": { | ||
| "errors": [ | ||
| "LoRaWAN reserved payload type" |
Contributor
There was a problem hiding this comment.
- "LoRaWAN reserved payload type",
+ "Unrecognised type for uplink decoding",
| }, | ||
| "output": { | ||
| "errors": [ | ||
| "V1 Deprecated Payload, unsupported" |
Contributor
There was a problem hiding this comment.
- "V1 Deprecated Payload, unsupported",
+ "Unrecognised type for uplink decoding",
| }, | ||
| "output": { | ||
| "errors": [ | ||
| "Unrecognised type for downlink decoding" |
Contributor
There was a problem hiding this comment.
- "errors": Array [
- "Unrecognised type for downlink decoding",
- ],
+ "data": Object {
+ "events": undefined,
+ "maxC": 0,
+ "minC": 0,
+ "reports": undefined,
+ "sensor_id": 0,
+ "timestamp": 0,
+ },
+ "errors": Array [],
Comment on lines
+394
to
+397
| "bytes": "0000000000000000004A", | ||
| "fPort": 2, | ||
| "errors": [], | ||
| "warnings": [] |
Contributor
There was a problem hiding this comment.
- "bytes": Array [
- 0,
- 0,
- 0,
- 0,
- 0,
- 0,
- 0,
- 0,
- 0,
- 74,
+ "errors": Array [
+ [TypeError: Cannot read properties of undefined (reading 'type')],
],
- "errors": Array [],
- "fPort": 2,
| }, | ||
| { | ||
| "type": "uplink", | ||
| "description": "fail decode uplink due to invalid port", |
Contributor
There was a problem hiding this comment.
All examples need to have a unique description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Wavetrend, including SD01-L-V2 Water Temperature Monitor
Driver tests did not work locally on MacOs due to problems with
isolated-vmpackage.