Origin/feature/navigation #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added navigation trough sections with left, right, up, down keys.
Features added: 1) Arrow Navigation: Top and Left have the same function AND Bottom and Right have the same function. 2) 5 classes on a given page instead of 8 so there's no whitespace. 3) Navigation through the page numbers (numbers and formatting ie I've made everything center aligned and added those first and last page buttons) 4) First course selected by default.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Notes: Fonts, landing page, and Dark Mode are on Bennet's branch. TODO after merging with Bennett's branch: dark mode colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added: 1) Arrow Navigation: Top and Bottom move through the page whereas Left and Right move through Sections. Ctrl + / (or Cmd) goes to the Search button, 2) 5 classes on a given page instead of 8 so there's no white-space. 3) Navigation through the page numbers (numbers and formatting ie I've made everything center aligned and added those first and last page buttons) 4) First course selected by default, 5) Arrows only affect section selection when "activated" and not anything in the search bar (Ie, if there is no section for a given query, arrows should move the page up and down), 6) Color changes (gray and black instead of blue).