This repository was archived by the owner on May 27, 2025. It is now read-only.
forked from vlaskine/comma
-
Notifications
You must be signed in to change notification settings - Fork 16
fix (some) build errors for new software versions #67
Open
mimhoff
wants to merge
1,070
commits into
acfr:master
Choose a base branch
from
mimhoff:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he list of valueless options
…and multiple sources implemented and tested
Switch to deque for flexability. Add convenience function pop all element.
…he miss slowdown: added and commented out
…cpy speedup: added and commented out
… parameter; unit test: negative test made more outrageous, otherwise yaml swallows anything
…itch statement: case 2: replaced with default:
…nt); otherwise, it does not compile if point and index types are the same
…added; in progress...
…ing: in progress...
…gging: in progress...
…gging: in progress...
… basics tested; Map.at(point, radius): in progress...
… basics tested; Map.at(point, radius): in progress...
…cut implemented and tested
…() since the former is deprecated and will be removed - supposedly from c++17, but gcc seems to still support it
to avoid the most vexing parse which confuses gcc 9 https://en.wikipedia.org/wiki/Most_vexing_parse
- eof() returns true only when all files are exhausted - read() only advances to next file when current file reaches EOF - test cases for istreams behaviour with single and multiple files
…ersion for backward compatibility as cmake 4 has discontinued support for anything less than 3.5
…efore running execlp(); otherwise pipelines like yes|csv-thin|csv-time-stamp do not exit if csv-time-stamp crashes (or is killed); the reason is that lots of applications (in comma and snark anyway) don't enable SIGPIPE handler explicitly and rely on default, which is inherited from the process calling exec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to build on Ubuntu 22.04.
Actually, comma seems to build fine without these - but snark fails.
boost::regex has been moved to std
boost::bind no longer uses global constants _1, _2, these are now in boost::placeholders namespace