Open
Conversation
- Downgrade Node.js base image from 24-alpine to 22-alpine in Dockerfile - Change application port from 3000 to 8000 in app.js - Update docker-compose.yml port mapping from 3000:3000 to 8000:8000 - Ensure consistency across Docker configuration and application settings
- Update page title to include author attribution "by Jay" - Update body text to display full author name "by Jay Gohel" - Personalize the sample application with creator information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes updates made in the dev branch after forking the original sample Node.js project into my repository for testing and deployment practice.
The Node.js runtime version has been updated to v22, and the application port has been changed from the default to 8000 to align with my containerized deployment setup. I also slightly modified the frontend title text to “Sample Node.js Application by Jay Gohel” so it’s easier to visually confirm that the deployed version is coming from this updated branch during testing.
In addition to these changes, I created a Dockerfile to containerize the application and verified that it builds and runs correctly on an AWS EC2 (Ubuntu 24.04) instance. A Jenkins pipeline was configured in my forked repository with a GitHub webhook, so pushes to the dev branch automatically trigger build and redeployment of the Docker container.
All changes have been tested in the dev environment and the application is running successfully in Docker.
Requesting review and merge into the main repository.