Skip to content

Sketch 85 Compatibility #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonburn wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Sketch 85 Compatibility #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UserFlows.sketchplugin/Contents/Sketch/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
"compatibleVersion" : "52" ,
"disableCocoaScriptPreprocessor" : true,
"identifier" : "com.abynim.sketchplugins.userflows",
"version" : "2.3",
"version" : "2.3.1",
"description" : "Generate user-flow diagrams from artboards in Sketch.",
"homepage" : "https:\/\/abynim.github.io\/UserFlows",
"authorEmail" : "abynimbalkar@gmail.com",
Expand Down
13 changes: 6 additions & 7 deletions UserFlows.sketchplugin/Contents/Sketch/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ var editConditionsForArtboard = function(currentArtboard, context, forceNewCondi
conditionBorder.setThickness(2);

conditionBoard.addLayers([conditionBox, conditionLabel]);
layersArray = MSLayerArray.arrayWithLayers([conditionBox, conditionLabel]);
layersArray = [conditionBox, conditionLabel];
conditionGroup = sketchVersion < sketchVersion52 ? MSLayerGroup.groupFromLayers(layersArray) : MSLayerGroup.groupWithLayers(layersArray);
conditionGroup.setName(strings["addCondition-conditionGroupName"] + " " + count);

Expand Down Expand Up @@ -1151,7 +1151,7 @@ var generateFlowWithSettings = function(context, settings, initialArtboard, sour
}

var sharedLayerStyles = sharedLayerStylesForContext(context);
var connectionLayers = MSLayerArray.arrayWithLayers(drawConnections(connections, sourcePage, exportScale, flowBackgroundColor, sharedLayerStyles));
var connectionLayers = drawConnections(connections, sourcePage, exportScale, flowBackgroundColor, sharedLayerStyles);
var connectionsGroup = sketchVersion < sketchVersion52 ? MSLayerGroup.groupFromLayers(connectionLayers) : MSLayerGroup.groupWithLayers(connectionLayers);
connectionsGroup.setName(strings["generateFlow-connectionsGroupName"]);
artboardBitmapLayers.push(connectionsGroup);
Expand All @@ -1161,7 +1161,7 @@ var generateFlowWithSettings = function(context, settings, initialArtboard, sour
for (var i = 0; i < artboardBitmapLayers.length; i++) {
groupBounds = CGRectUnion(groupBounds, artboardBitmapLayers[i].absoluteRect().rect());
}
var layers = MSLayerArray.arrayWithLayers(artboardBitmapLayers);
var layers = artboardBitmapLayers;
var newGroup = sketchVersion < sketchVersion52 ? MSLayerGroup.groupFromLayers(layers) : MSLayerGroup.groupWithLayers(layers);
newGroup.setName(strings["generateFlow-flowGroupName"]);
newGroup.resizeToFitChildrenWithOption(1);
Expand Down Expand Up @@ -1450,7 +1450,7 @@ var sharedLayerStylesForContext = function(context) {

var redrawConnections = function(context) {
var doc = context.document || context.actionContext.document;
var selectedLayers = doc.selectedLayers().layers();
var selectedLayers = doc.selectedLayers();

sketchVersion = getVersionNumberFromString(NSBundle.mainBundle().objectForInfoDictionaryKey("CFBundleShortVersionString"));

Expand Down Expand Up @@ -1504,12 +1504,11 @@ var redrawConnections = function(context) {
}

var sharedLayerStyles = sharedLayerStylesForContext(context);
var connectionLayers = MSLayerArray.arrayWithLayers(drawConnections(connections, doc.currentPage(), 1, nil, sharedLayerStyles));
var connectionLayers = drawConnections(connections, doc.currentPage(), 1, nil, sharedLayerStyles);
connectionsGroup = sketchVersion < sketchVersion52 ? MSLayerGroup.groupFromLayers(connectionLayers) : MSLayerGroup.groupWithLayers(connectionLayers);
connectionsGroup.setName("-Connections");
connectionsGroup.setIsLocked(1);
connectionsGroup.deselectLayerAndParent();
context.command.setValue_forKey_onLayer_forPluginIdentifier(true, "isConnectionsContainer", connectionsGroup, kPluginDomain);
context.command.setValue_forKey_onLayer(true,"isConnectionsContainer",connectionsGroup);

var loop = selectedLayers.objectEnumerator(), selectedLayer;
while (selectedLayer = loop.nextObject()) {
Expand Down
11 changes: 11 additions & 0 deletions appcast.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@
<link>https://abynim.github.io/UserFlows</link>
<description>Generate flow diagrams from Artboards in Sketch</description>
<language>en</language>
<item>
<title>UserFlows 2.3.1</title>
<description>
<![CDATA[
<ul>
<li>Sketch 85 Compatibility</li>
</ul>
]]>
</description>
<enclosure url="https://github.com/abynim/UserFlows/archive/v2.zip" sparkle:version="2.3.1" />
</item>
<item>
<title>UserFlows 2.3</title>
<description>
Expand Down