Skip to content

Conversation

@abtreece
Copy link
Owner

Summary

Fix documentation that incorrectly marks the env backend as supporting watch mode.

Changes

  • Remove env from the watch mode feature list (line 21)
  • Change env backend table row to show ❌ for watch mode (line 266)

Before

- **Watch Mode**: Real-time config updates for supported backends (Consul, etcd, Redis, Zookeeper, env, file)

| [Env](pkg/backends/env/README.md) ||| None |

After

- **Watch Mode**: Real-time config updates for supported backends (Consul, etcd, Redis, Zookeeper, file)

| [Env](pkg/backends/env/README.md) ||| None |

Reference

From pkg/backends/env/README.md:127:

Watch mode is not supported for the env backend. Environment variables are only read at startup or when using interval mode.

Fixes #514

🤖 Generated with Claude Code

The env backend does not support watch mode - it only reads environment
variables at startup or during interval-based polling. Update README.md
to accurately reflect this:

- Remove 'env' from watch mode feature list
- Change env backend table row to show ❌ for watch mode

This aligns with the env backend README which explicitly states:
"Watch mode is not supported for the env backend."

Fixes #514
Copilot AI review requested due to automatic review settings January 26, 2026 02:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects documentation that incorrectly indicated the env backend supports watch mode, aligning it with the actual backend capabilities documented in pkg/backends/env/README.md.

Changes:

  • Removed env from the list of backends supporting watch mode in the features section
  • Updated the env backend table entry to show ❌ for watch mode support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.36%. Comparing base (ce83d60) to head (50b826f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   62.30%   62.36%   +0.05%     
==========================================
  Files          48       48              
  Lines        5420     5420              
==========================================
+ Hits         3377     3380       +3     
+ Misses       1834     1831       -3     
  Partials      209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abtreece abtreece merged commit 7126e69 into main Jan 26, 2026
14 checks passed
@abtreece abtreece deleted the fix/env-backend-watch-mode-docs branch January 26, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: env backend incorrectly marked as supporting watch mode

1 participant