-
Notifications
You must be signed in to change notification settings - Fork 3
feat: expose pool_size and pool_idle_timeout as configurable options #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add configurable connection pool settings for the HTTP client: - pool_size (default: 20) - number of connections in the pool - pool_idle_timeout (default: 5) - seconds before idle connections close This allows customers to tune connection pooling behavior based on their specific workload requirements.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis pull request introduces configurable HTTP connection pool settings to the Ruby SDK. Two new configuration attributes— Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ef31f69 to
69aecf2
Compare
69aecf2 to
a183ced
Compare
calthejuggler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Summary
pool_sizeconfig option (default: 20) to control connection pool sizepool_idle_timeoutconfig option (default: 5) to set idle connection timeout in secondsTest plan
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.