Fixed the non-deterministic behavior of tests in TkMapperServiceTest #940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the test execution order is changed, all five tests in file
TkMapperServiceTest.javawould show a non-deterministic behavior and output the following errors of two kinds:IllegalArgumentException: wrong number of argumentsIllegalMonitorStateException: current thread is not ownerThe root cause of these errors is that Salon generates a subclass proxy for the test class. When the test methods are non-final, the proxy would override them and route calls through Solon's AOP chain. With NonDex randomizing the iteration order, this proxy path intermittently mis-invokes methods and the above errors would be generated.
Commands to reproduce the errors:
Proposed Fix
The code changes are local and minimum. By changing the test method to final, we can avoid Solon overriding or intercepting them.
Involved Tests
TkMapperServiceTest.allTkMapperServiceTest.byIdTkMapperServiceTest.exampleQueryTkMapperServiceTest.rawMybatisQueryTkMapperServiceTest.logicDelInsert