Skip to content

feature: add get method with limit parameter to FileDictionaryStorage#20

Merged
minjae999 merged 1 commit intomainfrom
feature/dictioanry_get_all
Feb 11, 2026
Merged

feature: add get method with limit parameter to FileDictionaryStorage#20
minjae999 merged 1 commit intomainfrom
feature/dictioanry_get_all

Conversation

@minjae999
Copy link
Contributor

feature: add get method with limit parameter to DictionaryStorage protocol

feature: add get method with limit parameter to DictionaryStorage protocol
@minjae999 minjae999 self-assigned this Feb 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Walkthrough

DictionaryStorage 프로토콜에 get(limit: Limit) -> Promise<[Value], Error) 메서드를 추가하고, FileDictionaryStorage에서 구현했습니다. 이 메서드는 지정된 제한까지 여러 값을 검색할 수 있습니다.

Changes

Cohort / File(s) Summary
DictionaryStorage 프로토콜
Source/AppleStorage/DictionaryStorage.swift
새로운 공개 메서드 get(limit: Limit) -> Promise<[Value], Error) 선언 추가
FileDictionaryStorage 구현
Source/AppleStorage/Implement/FileDictionaryStorage.swift
프로토콜 메서드 구현: 현재 값을 캡처하여 배열로 변환한 후, .unlimited인 경우 전체 배열 반환, .count(let limit)인 경우 제한된 접두사 배열 반환

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 여러 값을 한 번에 쏘옥,
제한을 정해 꼭 맞춰 담고,
빠르게 약속된 결과를 주네요.
저장소는 이제 더욱 똑똑해졌어요!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 주요 변경사항인 DictionaryStorage 프로토콜에 get 메서드 추가를 명확하게 설명하지만, FileDictionaryStorage에만 국한된 것처럼 보여 일부 불완전함.
Description check ✅ Passed PR 설명은 DictionaryStorage 프로토콜과 FileDictionaryStorage 구현에 limit 파라미터가 있는 get 메서드를 추가하는 변경사항과 관련이 있음.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/dictioanry_get_all

Comment @coderabbitai help to get the list of available commands and usage tips.

@minjae999 minjae999 requested review from 0xWOF and pokeum February 11, 2026 05:01
@minjae999 minjae999 merged commit d4818f5 into main Feb 11, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants