Skip to content

fix: fixed potential Objective-C method conflict#16

Closed
minjae999 wants to merge 1 commit intomainfrom
fix/conflict-objc
Closed

fix: fixed potential Objective-C method conflict#16
minjae999 wants to merge 1 commit intomainfrom
fix/conflict-objc

Conversation

@minjae999
Copy link
Contributor

같은 Framework사용시에 Objc 이름 충돌이 발생함을 수정
SabyCoreDataArrayStorageItemVersion1의 경우 internal과 사용하는 곳에서 @objc를 붙이지 않았기에 불필요한 심볼로 판단이 됨.

@minjae999 minjae999 requested a review from 0xWOF September 25, 2025 03:20
@minjae999 minjae999 self-assigned this Sep 25, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

CoreDataArrayStorage.swift에서 NSManagedObject 서브클래스 선언의 @objc 브리징 어노테이션이 제거되었습니다. 클래스 이름과 프로퍼티, 로직, 데이터 모델, 제어 흐름은 변경되지 않았습니다. 변경 범위는 Obj-C 노출 형태에 한정됩니다.

Changes

Cohort / File(s) Summary
Obj-C 노출 어노테이션 제거
Source/AppleStorage/Implement/CoreDataArrayStorage.swift
@objc(SabyCoreDataArrayStorageItemVersion1) 제거. Swift 전용 선언으로 유지; 런타임 로직/제어 흐름 변경 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

귀를 쫑긋, 주석 한 줄 톡 떨어졌네
브리징의 다리 접고, 스위프트 길만 가네 🐇
데이터는 그대로, 흐름도 그대로
살금살금 깃발 흔들고: "정리 완료!"
톡—가벼워진 발걸음에 당근이 방긋 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed 제목이 Objective-C 메서드 충돌 수정이라는 핵심 변경 사항을 명확하고 간결하게 요약하여 변경 의도를 잘 전달합니다.
Description Check ✅ Passed 설명에서 동일 프레임워크 사용 시 발생하는 ObjC 이름 충돌 문제와 @objc 어노테이션 제거 이유가 구체적으로 언급되어 있어 변경 사항과 관련성이 충분합니다.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/conflict-objc

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e894bb4 and cd3cca2.

📒 Files selected for processing (1)
  • Source/AppleStorage/Implement/CoreDataArrayStorage.swift (0 hunks)
💤 Files with no reviewable changes (1)
  • Source/AppleStorage/Implement/CoreDataArrayStorage.swift
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: task-list-completed

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@0xWOF 0xWOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 objc 붙은 클래스로 write 된 db 파일을 현재의 objc 가 안붙은 클래스로 read 할때 호환성문제가 없는지 체크해주시고, 유닛테스트도 추가해주세요.

@minjae999 minjae999 closed this Dec 15, 2025
@minjae999 minjae999 deleted the fix/conflict-objc branch December 15, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants