Alternate fix for Issue #23 (revised) #26
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe mods to new release
Reflect new release version
… format and add new selector for list view
guess who edited locals before checking he'd git pulled
hudochenkov
reviewed
Jan 14, 2021
Remove name on request Co-authored-by: Aleks Hudochenkov <aleks@hudochenkov.com>
Contributor
|
This PR gets things working again for me! Thanks! |
|
Thank you! |
Author
|
(To Whom It May Concern : Dec 2022 updates mean List View didn't work unless documents were opened; active closed links now get a distinct ID so I've used that as selector instead. Apologies if I'm doing this wrong....) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hudochenkov was correct my previous fix actually wasn't. However I've found that for me at least their fix was insufficient alone and didn't work in List view. This version attempts to reconcile their and my patches so that combined this completely closes #23 ; I've tested on Chrome for Feedly in all 4 view modes (Title, Article, Magazine, Cards) and I believe it works correctly.